fix: infinite loop when whitespaceChars width is 0 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

griimick wants to merge 2 commits into charmbracelet:master from griimick:fix-108

griimick commented Oct 19, 2022

Fixes #108

This fixes the infinite loop mentioned in issue.


          fix: infinite loop when whitespaceChars width is 0

cf198ae

Author

griimick commented Oct 19, 2022 •

edited

Loading

Unrelated but there are more corner cases to withWhitespaceChars like,

".\n"
".\t"

Should we ignore runes with 0 PrintableRuneWidth (\n, \t) when used as whitespaceChars when rendering them?


          remove redundant condition

53152cd

griimick closed this by deleting the head repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet