chore: lint

Author: meowgorithm

attachments.go

@@ -1,3 +1,4 @@
+// Package main implements Pop, a tool for sending emails from your terminal.
 package main
 
 import (

email.go

@@ -59,9 +59,11 @@ func (m Model) sendEmailCmd() tea.Cmd {
 	}
 }
 
-const gmailSuffix = "@gmail.com"
-const gmailSMTPHost = "smtp.gmail.com"
-const gmailSMTPPort = 587
+const (
+	gmailSuffix   = "@gmail.com"
+	gmailSMTPHost = "smtp.gmail.com"
+	gmailSMTPPort = 587
+)
 
 func sendSMTPEmail(to, cc, bcc []string, from, subject, body string, attachments []string) error {
 	server := mail.NewSMTPClient()
@@ -100,9 +102,8 @@ func sendSMTPEmail(to, cc, bcc []string, from, subject, body string, attachments
 	}
 
 	smtpClient, err := server.Connect()
-
 	if err != nil {
-		return err
+		return fmt.Errorf("connecting to SMTP server: %w", err)
 	}
 
 	email := mail.NewMSG()
@@ -128,10 +129,10 @@ func sendSMTPEmail(to, cc, bcc []string, from, subject, body string, attachments
 		})
 	}
 
-	return email.Send(smtpClient)
+	return fmt.Errorf("sending email: %w", email.Send(smtpClient))
 }
 
-func sendResendEmail(to, _, _ []string, from, subject, body string, attachments []string) error {
+func sendResendEmail(to, cc, bcc []string, from, subject, body string, attachments []string) error {
 	client := resend.NewClient(resendAPIKey)
 
 	html := bytes.NewBufferString("")
@@ -165,7 +166,7 @@ func sendResendEmail(to, _, _ []string, from, subject, body string, attachments
 
 	_, err := client.Emails.Send(request)
 	if err != nil {
-		return err
+		return fmt.Errorf("sending email via Resend: %w", err)
 	}
 
 	return nil
@@ -198,7 +199,7 @@ func saveTmp(s string) (string, error) {
 	if err != nil {
 		return "", fmt.Errorf("creating temp file: %w", err)
 	}
-	defer f.Close()
+	defer func() { _ = f.Close() }()
 
 	_, err = f.WriteString(s)
 	if err != nil {

main.go

@@ -43,7 +43,7 @@ const PopSMTPUsername = "POP_SMTP_USERNAME"
 const PopSMTPPassword = "POP_SMTP_PASSWORD" //nolint:gosec
 
 // PopSMTPEncryption is the encryption type for the SMTP server if the user is using the SMTP delivery method.
-const PopSMTPEncryption = "POP_SMTP_ENCRYPTION" //nolint:gosec
+const PopSMTPEncryption = "POP_SMTP_ENCRYPTION"
 
 // PopSMTPInsecureSkipVerify is whether or not to skip TLS verification for the
 // SMTP server if the user is using the SMTP delivery method.
@@ -73,7 +73,7 @@ var rootCmd = &cobra.Command{
 	Use:   "pop",
 	Short: "Send emails from your terminal",
 	Long:  `Pop is a tool for sending emails from your terminal.`,
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(cmd *cobra.Command, _ []string) error {
 		var deliveryMethod DeliveryMethod
 		switch {
 		case resendAPIKey != "" && smtpUsername != "" && smtpPassword != "":
@@ -101,12 +101,13 @@ var rootCmd = &cobra.Command{
 			cmd.SilenceUsage = true
 			cmd.SilenceErrors = true
 			return errors.New("unknown delivery method")
+		case Resend, SMTP:
 		}
 
 		if body == "" && hasStdin() {
 			b, err := io.ReadAll(os.Stdin)
 			if err != nil {
-				return err
+				return fmt.Errorf("reading stdin: %w", err)
 			}
 			body = string(b)
 		}
@@ -147,7 +148,7 @@ var rootCmd = &cobra.Command{
 
 		m, err := p.Run()
 		if err != nil {
-			return err
+			return fmt.Errorf("running program: %w", err)
 		}
 		mm := m.(Model)
 		if !mm.abort {
@@ -167,7 +168,7 @@ var (
 	// Version stores the build version of VHS at the time of package through
 	// -ldflags.
 	//
-	// go build -ldflags "-s -w -X=main.Version=$(VERSION)"
+	// go build -ldflags "-s -w -X=main.Version=$(VERSION)".
 	Version string
 
 	// CommitSHA stores the git commit SHA at the time of package through -ldflags.
@@ -182,9 +183,9 @@ var ManCmd = &cobra.Command{
 	Args:   cobra.NoArgs,
 	Hidden: true,
 	RunE: func(_ *cobra.Command, _ []string) error {
-		page, err := mcobra.NewManPage(1, rootCmd) // .
+		page, err := mcobra.NewManPage(1, rootCmd)
 		if err != nil {
-			return err
+			return fmt.Errorf("generating man page: %w", err)
 		}
 
 		page = page.WithSection("Copyright", "© 2023 Charmbracelet, Inc.\n"+"Released under MIT License.")

model.go

@@ -89,7 +89,6 @@ func NewModel(defaults resend.SendEmailRequest, deliveryMethod DeliveryMethod) M
 	from := textinput.New()
 	from.Prompt = "From "
 	from.Placeholder = "me@example.com"
-	from.PromptStyle = labelStyle.Copy()
 	from.PromptStyle = labelStyle
 	from.TextStyle = textStyle
 	from.Cursor.Style = cursorStyle
@@ -98,7 +97,7 @@ func NewModel(defaults resend.SendEmailRequest, deliveryMethod DeliveryMethod) M
 
 	to := textinput.New()
 	to.Prompt = "To "
-	to.PromptStyle = labelStyle.Copy()
+	to.PromptStyle = labelStyle
 	to.Cursor.Style = cursorStyle
 	to.PlaceholderStyle = placeholderStyle
 	to.TextStyle = textStyle
@@ -107,7 +106,7 @@ func NewModel(defaults resend.SendEmailRequest, deliveryMethod DeliveryMethod) M
 
 	cc := textinput.New()
 	cc.Prompt = "Cc "
-	cc.PromptStyle = labelStyle.Copy()
+	cc.PromptStyle = labelStyle
 	cc.Cursor.Style = cursorStyle
 	cc.PlaceholderStyle = placeholderStyle
 	cc.TextStyle = textStyle
@@ -116,7 +115,7 @@ func NewModel(defaults resend.SendEmailRequest, deliveryMethod DeliveryMethod) M
 
 	bcc := textinput.New()
 	bcc.Prompt = "Bcc "
-	bcc.PromptStyle = labelStyle.Copy()
+	bcc.PromptStyle = labelStyle
 	bcc.Cursor.Style = cursorStyle
 	bcc.PlaceholderStyle = placeholderStyle
 	bcc.TextStyle = textStyle
@@ -125,7 +124,7 @@ func NewModel(defaults resend.SendEmailRequest, deliveryMethod DeliveryMethod) M
 
 	subject := textinput.New()
 	subject.Prompt = "Subject "
-	subject.PromptStyle = labelStyle.Copy()
+	subject.PromptStyle = labelStyle
 	subject.Cursor.Style = cursorStyle
 	subject.PlaceholderStyle = placeholderStyle
 	subject.TextStyle = textStyle
@@ -221,7 +220,7 @@ func (m Model) Init() tea.Cmd {
 type clearErrMsg struct{}
 
 func clearErrAfter(d time.Duration) tea.Cmd {
-	return tea.Tick(d, func(t time.Time) tea.Msg {
+	return tea.Tick(d, func(_ time.Time) tea.Msg {
 		return clearErrMsg{}
 	})
 }
@@ -266,6 +265,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 				m.state = hoveringSendButton
 			case hoveringSendButton:
 				m.state = editingFrom
+			case pickingFile, sendingEmail:
 			}
 			m.focusActiveInput()
 
@@ -292,6 +292,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 				m.state = editingBody
 			case hoveringSendButton:
 				m.state = editingAttachments
+			case pickingFile, sendingEmail:
 			}
 			m.focusActiveInput()
 
@@ -353,6 +354,7 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 	case sendingEmail:
 		m.loadingSpinner, cmd = m.loadingSpinner.Update(msg)
 		cmds = append(cmds, cmd)
+	case editingFrom, editingTo, editingCc, editingBcc, editingSubject, editingBody, hoveringSendButton:
 	}
 
 	m.help, cmd = m.help.Update(msg)
@@ -419,6 +421,7 @@ func (m *Model) focusActiveInput() {
 	case editingAttachments:
 		m.Attachments.Styles.Title = activeLabelStyle
 		m.Attachments.SetDelegate(attachmentDelegate{true})
+	case hoveringSendButton, pickingFile, sendingEmail:
 	}
 }
 
@@ -434,6 +437,7 @@ func (m Model) View() string {
 			"\n\n" + m.filepicker.View()
 	case sendingEmail:
 		return "\n " + m.loadingSpinner.View() + "Sending email"
+	case editingFrom, editingTo, editingCc, editingBcc, editingSubject, editingBody, editingAttachments, hoveringSendButton:
 	}
 
 	var s strings.Builder

style.go

@@ -1,3 +1,4 @@
+// Package main implements Pop, a tool for sending emails from your terminal.
 package main
 
 import (
@@ -6,12 +7,14 @@ import (
 	"github.com/charmbracelet/lipgloss"
 )
 
-const accentColor = lipgloss.Color("99")
-const yellowColor = lipgloss.Color("#ECFD66")
-const whiteColor = lipgloss.Color("255")
-const grayColor = lipgloss.Color("241")
-const darkGrayColor = lipgloss.Color("236")
-const lightGrayColor = lipgloss.Color("247")
+const (
+	accentColor    = lipgloss.Color("99")
+	yellowColor    = lipgloss.Color("#ECFD66")
+	whiteColor     = lipgloss.Color("255")
+	grayColor      = lipgloss.Color("241")
+	darkGrayColor  = lipgloss.Color("236")
+	lightGrayColor = lipgloss.Color("247")
+)
 
 var (
 	activeTextStyle = lipgloss.NewStyle().Foreground(whiteColor)