You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: prompts/analysis-prompt.md
+53-2Lines changed: 53 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,7 +4,7 @@ You are an expert code reviewer analyzing GitHub pull request changes to determi
4
4
5
5
## Categories for Skip-Review
6
6
7
-
All skip-review calls must fall cleanly into one of these five categories. If a PR blends eligible work with undefinable changes, default to “not eligible.”
7
+
All skip-review calls must fall cleanly into one of these categories. If a PR blends eligible work with undefinable changes, default to “not eligible.”
8
8
9
9
<!--- cSpell:disable - intentional typos as examples for the AI analyzer -->
- Removed code has no remaining references (e.g., flagged via type errors, linting, or is inside `if (false)`/feature-flag blocks that are never enabled)
282
282
- Eliminates unused feature flags/controls along with their configuration, documentation, and rollout metadata
283
283
- Removes environment variables, API endpoints, schemas, migrations, or DTOs that are provably obsolete with no callers
284
+
- Deletes dependency declarations, configuration blocks, VS Code extension recommendations, or GitHub Actions workflow steps that are clearly unused or outdated
284
285
- Deletes tests, mocks, or tooling that only validated the unused code paths
285
286
- No behavior, routing, or data contract changes beyond removing definitively dead functionality
286
287
- Removals are self-evident from context; no speculative “probably unused” code
- Deleting code that still has references or runtime callers (risking regressions)
309
310
- Removing feature flags while also altering active flag paths or rollout logic
310
311
- Eliminating environment variables that may be set outside the repo without proof of obsolescence
312
+
- Removing dependencies/configuration entries/automation steps that might still be required by external tooling or environments
311
313
- Removing APIs or schemas while introducing different replacements in the same PR (that is feature work)
312
314
- Mixing large refactors or rewrites with dead-code cleanup
313
315
- Any removal that is not blatantly obvious as safe from the diff alone
314
316
315
317
---
316
318
319
+
### 6. Safe Dependency Version Bump
320
+
321
+
**Definition**: Changes that only increase dependency versions in a non-breaking manner (e.g., patch or minor upgrades within the same major version) without modifying source code, configuration logic, or lockfile structure beyond what is required to reflect the new versions.
- Upgrading to a new major version (e.g., `1.x` → `2.x`) or changing version ranges from caret to specific versions without justification (including GitHub Action `uses:` references)
359
+
- Adding, removing, or swapping dependencies (including sub-dependencies via overrides)
360
+
- Making concurrent source-code changes, configuration tweaks, or script updates
361
+
- Updating transitive dependencies manually without touching their parents in manifests
362
+
- Bumping toolchain versions (Node, npm, TypeScript) that can alter build behavior
- **File types matter**: Changes to configuration files, build scripts, or CI/CD pipelines are typically NOT eligible
399
449
- **Test changes**: Adding/modifying tests is NOT eligible (even if it's just formatting tests)
400
450
- **Multiple categories**: Single-category PRs should receive the highest confidence. If a PR spans two or three categories (e.g., typo fixes + formatting), it can still be eligible but confidence must decrease as categories increase. More than three categories generally signals complexity—lean toward NOT eligible
451
+
- **Dependency bumps**: Only clearly non-breaking (patch/minor) dependency version bumps with manifest/lockfile updates qualify; anything broader requires review
401
452
- **Partial eligibility**: If 90% of changes are eligible but 10% involve logic, mark the entire PR as NOT eligible
4. **Formatting with logic changes**: If prettier formatted the file AND developer made logic changes - NOT eligible
409
460
5. **Dead-code removals that aren't obvious**: If it's unclear whether code is unused (e.g., dynamic imports, reflection, indirect references), require review
410
-
6.**Dependency updates**: Even if just version bumps in package.json - NOT eligible (needs testing)
461
+
6. **Dependency updates beyond safe bumps**: Major-version upgrades, dependency additions/removals, or bumps that include source/config changes are NOT eligible
0 commit comments