Hi @kyleecodes

So I tried my best to make all the changes and I think I have covered them all here. I also updated the test cases wherever it was required.

Since this required making changes in test cases also, I am not sure about whatever I have done is correct or not. So if possible can you please take a look at my PR?

if it looks ok, then I will start making changes in the frontend repo and will run the full unit tests as well as e2e tests there using playwright.

Hey thanks for this! After an initial look, most of it looks great. I realised that I hadn't checked the changes in the webhook to see what storyblok was sending instead of story_id. It seems like they haven't changed to sending the uuid ryet in the body of the webhook. I am going to follow up with support and let you know what they say and then I'll finish my review after I get the answer from them. Hope thats okay!

Just had a message back from storyblok:

My suggestion would be keep the webhook as it was and we can migrate the webhook to just using the uuid at a later date. Apologies for that!

Thanks for the review.

I'll update this PR to revert the webhook to use the story_id in sometime.

Hi @eleanorreem , I have a doubt regarding keeping the storyblokId in the webhook.

From my understanding, what I can see is that in the functionhandleStoryUpdated in the webhook.service.ts file, we won't have access to the uuid.

So whatever actions we are performing in that file, we need to use storyblokId instead of storyblokUuid.

But in the functions in that service, we make calls to sessionRepository, courseRepository etc. where I replaced storyblokId with storyblokUuid in their entities. So should I keep both uuid and id those entities or just keep storyblokId as of now?

Hi @strawHat121 I wasn't clear apologies. I agree with you. Keep both for now in the webhook and use storyblokUuid elsewhere! And then when they fully migrate away from the legacy storyblokId, we can remove it from our code base.

Hi @eleanorreem

I have reverted the changes in the webhook service and I have kept both storyblokId and storyblokUuid in the entities that are being called in webhook.

I have made changes in the tests as well.

But few tests are failing (and these are also failing in develop) because the ISbStoryData that is used to define the type of data in updateOrCreateStoryData doesn't contain any id field. Seems like the interface that they provide doesn't have any id field in it which seems weird. But I am not sure what to do about that.

Apart from this I tried my best to make the changes.

Let me know if any more changes are required.

Thanks @strawHat121 all merged ⭐