Merge branch 'main' into ferran/sc-0/detect-pw-version

Author: ferrandiaz

packages/cli/src/constructs/api-check.ts

@@ -236,6 +236,8 @@ export class ApiCheck extends RuntimeCheck {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (this.setupScript) {
       if (!isEntrypoint(this.setupScript) && !isContent(this.setupScript)) {
         diagnostics.add(new InvalidPropertyValueDiagnostic(

packages/cli/src/constructs/browser-check.ts

@@ -125,6 +125,8 @@ export class BrowserCheck extends RuntimeCheck {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (!isEntrypoint(this.code) && !isContent(this.code)) {
       diagnostics.add(new InvalidPropertyValueDiagnostic(
         'code',

packages/cli/src/constructs/check-group-v1.ts

@@ -371,6 +371,8 @@ export class CheckGroupV1 extends Construct {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     await this.onBeforeValidate(diagnostics)
 
     await this.validateDoubleCheck(diagnostics)

packages/cli/src/constructs/dashboard.ts

@@ -278,6 +278,8 @@ export class Dashboard extends Construct {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (!this.customUrl && !this.customDomain) {
       diagnostics.add(new InvalidPropertyValueDiagnostic(
         'customUrl',

packages/cli/src/constructs/multi-step-check.ts

@@ -55,6 +55,8 @@ export class MultiStepCheck extends RuntimeCheck {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (!isEntrypoint(this.code) && !isContent(this.code)) {
       diagnostics.add(new InvalidPropertyValueDiagnostic(
         'code',

packages/cli/src/constructs/playwright-check.ts

@@ -57,6 +57,8 @@ export class PlaywrightCheck extends RuntimeCheck {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     try {
       await fs.access(this.playwrightConfigPath, fs.constants.R_OK)
     } catch (err: any) {

packages/cli/src/constructs/private-location.ts

@@ -108,6 +108,8 @@ export class PrivateLocation extends Construct {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (!RE_SLUG.test(this.slugName)) {
       diagnostics.add(new InvalidPropertyValueDiagnostic(
         'slugName',

packages/cli/src/constructs/project.ts

@@ -93,6 +93,8 @@ export class Project extends Construct {
   }
 
   async validate (diagnostics: Diagnostics): Promise<void> {
+    await super.validate(diagnostics)
+
     if (!this.name) {
       diagnostics.add(new InvalidPropertyValueDiagnostic(
         'name',

packages/cli/src/constructs/retry-strategy.ts

@@ -162,6 +162,7 @@ export class RetryStrategyBuilder {
       maxRetries: options?.maxRetries ?? RetryStrategyBuilder.DEFAULT_MAX_RETRIES,
       maxDurationSeconds: options?.maxDurationSeconds ?? RetryStrategyBuilder.DEFAULT_MAX_DURATION_SECONDS,
       sameRegion: options?.sameRegion ?? RetryStrategyBuilder.DEFAULT_SAME_REGION,
+      onlyOn: options?.onlyOn,
     }
   }
 }