refactor: better code readability

jan-osch · jan-osch · commit ec6fc8fbc42e · 2025-01-21T11:42:00.000+01:00
diff --git a/vue/src/components/Topbar.vue b/vue/src/components/Topbar.vue
@@ -167,7 +167,8 @@ export default {
     signIn() {
       this.error = ''
 
-      if (!this.email || !this.password) {
+      const fieldsMissing = this.email || !this.password
+      if (fieldsMissing) {
         this.error = 'Please fill in all fields.'
         return
       }

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,8 @@ export default {`
`167`	`167`	`signIn() {`
`168`	`168`	`this.error = ''`
`169`	`169`
`170`		`- if (!this.email \|\| !this.password) {`
	`170`	`+ const fieldsMissing = this.email \|\| !this.password`
	`171`	`+ if (fieldsMissing) {`
`171`	`172`	`this.error = 'Please fill in all fields.'`
`172`	`173`	`return`
`173`	`174`	`}`