Types fix

Author: david-ruiz-cko

src/main/java/com/checkout/payments/ProcessingSettings.java

@@ -37,7 +37,7 @@ public final class ProcessingSettings {
      * The total amount of sales tax on the total purchase amount.
      * [Optional]
      */
-    private Long taxAmount;
+    private Double taxAmount;
 
     /**
      * The surcharge amount applied to the transaction in minor currency units by the merchant.
@@ -49,25 +49,25 @@ public final class ProcessingSettings {
      * The discount amount applied to the transaction by the merchant.
      * [Optional]
      */
-    private Long discountAmount;
+    private Double discountAmount;
 
     /**
      * The total charges for any import or export duty included in the transaction.
      * [Optional]
      */
-    private Long dutyAmount;
+    private Double dutyAmount;
 
     /**
      * The total freight or shipping and handling charges for the transaction.
      * [Optional]
      */
-    private Long shippingAmount;
+    private Double shippingAmount;
 
     /**
      * The tax amount on the freight or shipping and handling charges for the transaction.
      * [Optional]
      */
-    private Long shippingTaxAmount;
+    private Double shippingTaxAmount;
 
     /**
      * Indicates if the payment is an Account Funding Transaction (AFT).
@@ -111,7 +111,7 @@ public final class ProcessingSettings {
      * The original order amount when a payment is split. Indicates the full order price.
      * [Optional]
      */
-    private Long originalOrderAmount;
+    private Double originalOrderAmount;
 
     /**
      * Merchant receipt ID.

src/main/java/com/checkout/payments/contexts/PaymentContextsProcessing.java

@@ -31,19 +31,19 @@ public final class PaymentContextsProcessing {
      * The discount amount the merchant applied to the transaction.
      * [Optional]
      */
-    private Integer discountAmount;
+    private Double discountAmount;
 
     /**
      * The total freight or shipping and handling charges for the transaction.
      * [Optional]
      */
-    private Integer shippingAmount;
+    private Double shippingAmount;
 
     /**
      * The total tax amount for the transaction, in the minor currency unit.
      * [Optional]
      */
-    private Integer taxAmount;
+    private Double taxAmount;
 
     /**
      * Invoice ID number.

src/main/java/com/checkout/payments/response/ProcessingData.java

@@ -48,7 +48,7 @@ public final class ProcessingData {
      * Total tax amount of the order.
      * [Optional]
      */
-    private Long taxAmount;
+    private Double taxAmount;
 
     /**
      * The country where the purchase was made. ISO 3166-1 alpha-2 country code.

src/test/java/com/checkout/payments/CaptureTestIT.java

@@ -168,17 +168,17 @@ private ProductRequest createProductRequest() {
     private ProcessingSettings createProcessingSettings() {
         return ProcessingSettings.builder()
                 .orderId("123456789")
-                .taxAmount(3000L)
-                .discountAmount(0L)
-                .dutyAmount(0L)
-                .shippingAmount(300L)
-                .shippingTaxAmount(100L)
+                .taxAmount(3000d)
+                .discountAmount(0d)
+                .dutyAmount(0d)
+                .shippingAmount(300d)
+                .shippingTaxAmount(100d)
                 .aft(true)
                 .preferredScheme(PreferredSchema.MASTERCARD)
                 .merchantInitiatedReason(MerchantInitiatedReason.DELAYED_CHARGE)
                 .productType(ProductType.QR_CODE)
                 .openId("oUpF8uMuAJO_M2pxb1Q9zNjWeS6o")
-                .originalOrderAmount(10L)
+                .originalOrderAmount(10d)
                 .receiptId("10")
                 .terminalType(TerminalType.WAP)
                 .osType(OsType.ANDROID)

src/test/java/com/checkout/payments/RequestApmPaymentsIT.java

@@ -658,7 +658,7 @@ private PaymentRequest createTamaraPaymentRequest() {
                 .successUrl("https://testing.checkout.com/success")
                 .failureUrl("https://testing.checkout.com/failure")
                 .reference("ORD-5023-4E89")
-                .processing(ProcessingSettings.builder().taxAmount(500L).shippingAmount(1000L).build())
+                .processing(ProcessingSettings.builder().taxAmount(500d).shippingAmount(1000d).build())
                 .processingChannelId("pc_zs5fqhybzc2e3jmq3efvybybpq")
                 .customer(createTamaraCustomer())
                 .items(Collections.singletonList(createTamaraProduct()))

src/test/java/com/checkout/serialization/CustomDeserializerPolicyTest.java

@@ -8,7 +8,9 @@
 import com.checkout.payments.PaymentAction;
 import com.checkout.payments.Passenger;
 import com.checkout.payments.AirlineData;
+import com.checkout.payments.ProcessingSettings;
 import com.checkout.payments.ProductResponse;
+import com.checkout.payments.response.ProcessingData;
 import com.google.gson.reflect.TypeToken;
 import org.junit.jupiter.api.Test;
 
@@ -34,6 +36,44 @@ class CustomDeserializerPolicyTest {
      * getProductDeserializer matches JSON keys against @SerializedName, the exact field name, OR the
      * naming-policy translation. This verifies snake_case keys map to annotation-less camelCase fields.
      */
+    // The swagger types tax_amount, discount_amount, shipping_amount, shipping_tax_amount,
+    // duty_amount and original_order_amount as `number`, not `integer`, and the live API honours
+    // that: POST /payments with "tax_amount": 10.5 returns 201 and GET /payments/{id} echoes 10.5
+    // back. While these fields were Long, Gson threw
+    // JsonSyntaxException: NumberFormatException: Expected a long but was 10.5 on that response,
+    // so the whole payment failed to deserialize. Keep them Double.
+    @Test
+    void processingAcceptsFractionalAmounts() {
+        final String json = "{\"tax_amount\":10.5,\"discount_amount\":0.25,"
+                + "\"shipping_amount\":3.75,\"shipping_tax_amount\":1.5,"
+                + "\"duty_amount\":2.05,\"original_order_amount\":99.99}";
+
+        final ProcessingSettings settings = serializer.fromJson(json, ProcessingSettings.class);
+
+        assertEquals(10.5d, settings.getTaxAmount());
+        assertEquals(0.25d, settings.getDiscountAmount());
+        assertEquals(3.75d, settings.getShippingAmount());
+        assertEquals(1.5d, settings.getShippingTaxAmount());
+        assertEquals(2.05d, settings.getDutyAmount());
+        assertEquals(99.99d, settings.getOriginalOrderAmount());
+    }
+
+    @Test
+    void processingDataAcceptsFractionalTaxAmount() {
+        final ProcessingData data =
+                serializer.fromJson("{\"tax_amount\":10.5}", ProcessingData.class);
+
+        assertEquals(10.5d, data.getTaxAmount());
+    }
+
+    @Test
+    void processingStillAcceptsWholeAmounts() {
+        final ProcessingSettings settings =
+                serializer.fromJson("{\"tax_amount\":3000}", ProcessingSettings.class);
+
+        assertEquals(3000d, settings.getTaxAmount());
+    }
+
     @Test
     void productDeserializer_honorsNamingPolicyWithoutSerializedName() {
         final String json = "{"