Description
criu-3.17 fails to build (with the needed backports: cd0ed7e and 2b3763f) if libdrm is installed without amdgpu support.
Originally reported downstream in Gentoo.
Steps to reproduce the issue:
- Install libdrm without amdgpu support.
- Try to build criu-3.17 (with above patches from git applied)
Describe the results you received:
Build failure:
amdgpu_plugin.c:20:10: fatal error: libdrm/amdgpu.h: No such file or directory
20 | #include <libdrm/amdgpu.h>
| ^~~~~~~~~~~~~~~~~
Describe the results you expected:
Successful build.
Additional information you deem important (e.g. issue happens only occasionally):
The check at https://github.com/checkpoint-restore/criu/blob/criu-dev/Makefile.config#L24 has two issues:
- it only checks for the presence of libdrm, not libdrm's amdgpu support;
- it's automagic (i.e. building criu will use libraries available on the system without giving a way to disable them, which can be an issue if e.g. building binaries for another system).
Additional environment details:
Gentoo.
Description
criu-3.17 fails to build (with the needed backports: cd0ed7e and 2b3763f) if libdrm is installed without amdgpu support.
Originally reported downstream in Gentoo.
Steps to reproduce the issue:
Describe the results you received:
Build failure:
Describe the results you expected:
Successful build.
Additional information you deem important (e.g. issue happens only occasionally):
The check at https://github.com/checkpoint-restore/criu/blob/criu-dev/Makefile.config#L24 has two issues:
Additional environment details:
Gentoo.