Skip to content

Commit 26c40d1

Browse files
committed
Revert "Upgraded caddy version from 2.9.1 to 2.11.2. (open-edge-platform#845)"
This reverts commit 8df4ba8.
1 parent 5c0308d commit 26c40d1

11 files changed

+685
-11
lines changed

SPECS/caddy/CVE-2024-45339.patch

Lines changed: 120 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,120 @@
1+
From afd4339ec8682b92eb6bcc870d138106ffd5f58d Mon Sep 17 00:00:00 2001
2+
From: kavyasree <kkaitepalli@microsoft.com>
3+
Date: Fri, 31 Jan 2025 21:16:51 +0530
4+
Subject: [PATCH] Patch CVE-2024-45339
5+
6+
Reference: https://github.com/golang/glog/pull/74
7+
8+
---
9+
vendor/github.com/golang/glog/glog_file.go | 60 ++++++++++++++++------
10+
1 file changed, 44 insertions(+), 16 deletions(-)
11+
12+
diff --git a/vendor/github.com/golang/glog/glog_file.go b/vendor/github.com/golang/glog/glog_file.go
13+
index e7d125c..6d239fa 100644
14+
--- a/vendor/github.com/golang/glog/glog_file.go
15+
+++ b/vendor/github.com/golang/glog/glog_file.go
16+
@@ -118,32 +118,53 @@ var onceLogDirs sync.Once
17+
// contains tag ("INFO", "FATAL", etc.) and t. If the file is created
18+
// successfully, create also attempts to update the symlink for that tag, ignoring
19+
// errors.
20+
-func create(tag string, t time.Time) (f *os.File, filename string, err error) {
21+
+func create(tag string, t time.Time, dir string) (f *os.File, filename string, err error) {
22+
+ if dir != "" {
23+
+ f, name, err := createInDir(dir, tag, t)
24+
+ if err == nil {
25+
+ return f, name, err
26+
+ }
27+
+ return nil, "", fmt.Errorf("log: cannot create log: %v", err)
28+
+ }
29+
+
30+
onceLogDirs.Do(createLogDirs)
31+
if len(logDirs) == 0 {
32+
return nil, "", errors.New("log: no log dirs")
33+
}
34+
- name, link := logName(tag, t)
35+
var lastErr error
36+
for _, dir := range logDirs {
37+
- fname := filepath.Join(dir, name)
38+
- f, err := os.Create(fname)
39+
+ f, name, err := createInDir(dir, tag, t)
40+
if err == nil {
41+
- symlink := filepath.Join(dir, link)
42+
- os.Remove(symlink) // ignore err
43+
- os.Symlink(name, symlink) // ignore err
44+
- if *logLink != "" {
45+
- lsymlink := filepath.Join(*logLink, link)
46+
- os.Remove(lsymlink) // ignore err
47+
- os.Symlink(fname, lsymlink) // ignore err
48+
- }
49+
- return f, fname, nil
50+
+ return f, name, err
51+
}
52+
lastErr = err
53+
}
54+
return nil, "", fmt.Errorf("log: cannot create log: %v", lastErr)
55+
}
56+
57+
+func createInDir(dir, tag string, t time.Time) (f *os.File, name string, err error) {
58+
+ name, link := logName(tag, t)
59+
+ fname := filepath.Join(dir, name)
60+
+ // O_EXCL is important here, as it prevents a vulnerability. The general idea is that logs often
61+
+ // live in an insecure directory (like /tmp), so an unprivileged attacker could create fname in
62+
+ // advance as a symlink to a file the logging process can access, but the attacker cannot. O_EXCL
63+
+ // fails the open if it already exists, thus prevent our this code from opening the existing file
64+
+ // the attacker points us to.
65+
+ f, err = os.OpenFile(fname, os.O_RDWR|os.O_CREATE|os.O_EXCL, 0666)
66+
+ if err == nil {
67+
+ symlink := filepath.Join(dir, link)
68+
+ os.Remove(symlink) // ignore err
69+
+ os.Symlink(name, symlink) // ignore err
70+
+ if *logLink != "" {
71+
+ lsymlink := filepath.Join(*logLink, link)
72+
+ os.Remove(lsymlink) // ignore err
73+
+ os.Symlink(fname, lsymlink) // ignore err
74+
+ }
75+
+ return f, fname, nil
76+
+ }
77+
+ return nil, "", err
78+
+}
79+
+
80+
// flushSyncWriter is the interface satisfied by logging destinations.
81+
type flushSyncWriter interface {
82+
Flush() error
83+
@@ -247,6 +268,7 @@ type syncBuffer struct {
84+
names []string
85+
sev logsink.Severity
86+
nbytes uint64 // The number of bytes written to this file
87+
+ madeAt time.Time
88+
}
89+
90+
func (sb *syncBuffer) Sync() error {
91+
@@ -254,9 +276,14 @@ func (sb *syncBuffer) Sync() error {
92+
}
93+
94+
func (sb *syncBuffer) Write(p []byte) (n int, err error) {
95+
+ // Rotate the file if it is too large, but ensure we only do so,
96+
+ // if rotate doesn't create a conflicting filename.
97+
if sb.nbytes+uint64(len(p)) >= MaxSize {
98+
- if err := sb.rotateFile(time.Now()); err != nil {
99+
- return 0, err
100+
+ now := timeNow()
101+
+ if now.After(sb.madeAt.Add(1*time.Second)) || now.Second() != sb.madeAt.Second() {
102+
+ if err := sb.rotateFile(now); err != nil {
103+
+ return 0, err
104+
+ }
105+
}
106+
}
107+
n, err = sb.Writer.Write(p)
108+
@@ -274,7 +301,8 @@ const footer = "\nCONTINUED IN NEXT FILE\n"
109+
func (sb *syncBuffer) rotateFile(now time.Time) error {
110+
var err error
111+
pn := "<none>"
112+
- file, name, err := create(sb.sev.String(), now)
113+
+ file, name, err := create(sb.sev.String(), now, "")
114+
+ sb.madeAt = now
115+
116+
if sb.file != nil {
117+
// The current log file becomes the previous log at the end of
118+
--
119+
2.34.1
120+

SPECS/caddy/CVE-2025-22869.patch

Lines changed: 139 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,139 @@
1+
From 041b89a18f81265899e42e6801f830c101a96120 Mon Sep 17 00:00:00 2001
2+
From: Kanishk-Bansal <kbkanishk975@gmail.com>
3+
Date: Sun, 2 Mar 2025 13:46:00 +0000
4+
Subject: [PATCH] CVE-2025-22869
5+
6+
Upstream Reference : https://github.com/golang/crypto/commit/7292932d45d55c7199324ab0027cc86e8198aa22
7+
8+
ssh: limit the size of the internal packet queue while waiting for KEX
9+
10+
In the SSH protocol, clients and servers execute the key exchange to
11+
generate one-time session keys used for encryption and authentication.
12+
The key exchange is performed initially after the connection is
13+
established and then periodically after a configurable amount of data.
14+
While a key exchange is in progress, we add the received packets to an
15+
internal queue until we receive SSH_MSG_KEXINIT from the other side.
16+
This can result in high memory usage if the other party is slow to
17+
respond to the SSH_MSG_KEXINIT packet, or memory exhaustion if a
18+
malicious client never responds to an SSH_MSG_KEXINIT packet during a
19+
large file transfer.
20+
We now limit the internal queue to 64 packets: this means 2MB with the
21+
typical 32KB packet size.
22+
When the internal queue is full we block further writes until the
23+
pending key exchange is completed or there is a read or write error.
24+
25+
Thanks to Yuichi Watanabe for reporting this issue.
26+
27+
Change-Id: I1ce2214cc16e08b838d4bc346c74c72addafaeec
28+
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/652135
29+
Reviewed-by: Neal Patel <nealpatel@google.com>
30+
Auto-Submit: Gopher Robot <gobot@golang.org>
31+
Reviewed-by: Roland Shoemaker <roland@golang.org>
32+
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
33+
34+
---
35+
vendor/golang.org/x/crypto/ssh/handshake.go | 47 ++++++++++++++++-----
36+
1 file changed, 37 insertions(+), 10 deletions(-)
37+
38+
diff --git a/vendor/golang.org/x/crypto/ssh/handshake.go b/vendor/golang.org/x/crypto/ssh/handshake.go
39+
index 70a7369..e14eb6c 100644
40+
--- a/vendor/golang.org/x/crypto/ssh/handshake.go
41+
+++ b/vendor/golang.org/x/crypto/ssh/handshake.go
42+
@@ -24,6 +24,11 @@ const debugHandshake = false
43+
// quickly.
44+
const chanSize = 16
45+
46+
+// maxPendingPackets sets the maximum number of packets to queue while waiting
47+
+// for KEX to complete. This limits the total pending data to maxPendingPackets
48+
+// * maxPacket bytes, which is ~16.8MB.
49+
+const maxPendingPackets = 64
50+
+
51+
// keyingTransport is a packet based transport that supports key
52+
// changes. It need not be thread-safe. It should pass through
53+
// msgNewKeys in both directions.
54+
@@ -58,11 +63,19 @@ type handshakeTransport struct {
55+
incoming chan []byte
56+
readError error
57+
58+
- mu sync.Mutex
59+
- writeError error
60+
- sentInitPacket []byte
61+
- sentInitMsg *kexInitMsg
62+
- pendingPackets [][]byte // Used when a key exchange is in progress.
63+
+ mu sync.Mutex
64+
+ // Condition for the above mutex. It is used to notify a completed key
65+
+ // exchange or a write failure. Writes can wait for this condition while a
66+
+ // key exchange is in progress.
67+
+ writeCond *sync.Cond
68+
+ writeError error
69+
+ sentInitPacket []byte
70+
+ sentInitMsg *kexInitMsg
71+
+ // Used to queue writes when a key exchange is in progress. The length is
72+
+ // limited by pendingPacketsSize. Once full, writes will block until the key
73+
+ // exchange is completed or an error occurs. If not empty, it is emptied
74+
+ // all at once when the key exchange is completed in kexLoop.
75+
+ pendingPackets [][]byte
76+
writePacketsLeft uint32
77+
writeBytesLeft int64
78+
79+
@@ -114,6 +127,7 @@ func newHandshakeTransport(conn keyingTransport, config *Config, clientVersion,
80+
81+
config: config,
82+
}
83+
+ t.writeCond = sync.NewCond(&t.mu)
84+
t.resetReadThresholds()
85+
t.resetWriteThresholds()
86+
87+
@@ -236,6 +250,7 @@ func (t *handshakeTransport) recordWriteError(err error) {
88+
defer t.mu.Unlock()
89+
if t.writeError == nil && err != nil {
90+
t.writeError = err
91+
+ t.writeCond.Broadcast()
92+
}
93+
}
94+
95+
@@ -339,6 +354,8 @@ write:
96+
}
97+
}
98+
t.pendingPackets = t.pendingPackets[:0]
99+
+ // Unblock writePacket if waiting for KEX.
100+
+ t.writeCond.Broadcast()
101+
t.mu.Unlock()
102+
}
103+
104+
@@ -526,11 +543,20 @@ func (t *handshakeTransport) writePacket(p []byte) error {
105+
}
106+
107+
if t.sentInitMsg != nil {
108+
- // Copy the packet so the writer can reuse the buffer.
109+
- cp := make([]byte, len(p))
110+
- copy(cp, p)
111+
- t.pendingPackets = append(t.pendingPackets, cp)
112+
- return nil
113+
+ if len(t.pendingPackets) < maxPendingPackets {
114+
+ // Copy the packet so the writer can reuse the buffer.
115+
+ cp := make([]byte, len(p))
116+
+ copy(cp, p)
117+
+ t.pendingPackets = append(t.pendingPackets, cp)
118+
+ return nil
119+
+ }
120+
+ for t.sentInitMsg != nil {
121+
+ // Block and wait for KEX to complete or an error.
122+
+ t.writeCond.Wait()
123+
+ if t.writeError != nil {
124+
+ return t.writeError
125+
+ }
126+
+ }
127+
}
128+
129+
if t.writeBytesLeft > 0 {
130+
@@ -547,6 +573,7 @@ func (t *handshakeTransport) writePacket(p []byte) error {
131+
132+
if err := t.pushPacket(p); err != nil {
133+
t.writeError = err
134+
+ t.writeCond.Broadcast()
135+
}
136+
137+
return nil
138+
--
139+
2.45.2

SPECS/caddy/CVE-2025-22872.patch

Lines changed: 58 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,58 @@
1+
From 9ba151b580e96d9fe4f9a400f91e726119546fff Mon Sep 17 00:00:00 2001
2+
From: Roland Shoemaker <roland@golang.org>
3+
Date: Mon, 24 Feb 2025 11:18:31 -0800
4+
Subject: [PATCH] html: properly handle trailing solidus in unquoted attribute
5+
value in foreign content
6+
7+
The parser properly treats tags like <p a=/> as <p a="/">, but the
8+
tokenizer emits the SelfClosingTagToken token incorrectly. When the
9+
parser is used to parse foreign content, this results in an incorrect
10+
DOM.
11+
12+
Thanks to Sean Ng (https://ensy.zip) for reporting this issue.
13+
14+
Fixes golang/go#73070
15+
Fixes CVE-2025-22872
16+
17+
Change-Id: I65c18df6d6244bf943b61e6c7a87895929e78f4f
18+
Reviewed-on: https://go-review.googlesource.com/c/net/+/661256
19+
Reviewed-by: Neal Patel <nealpatel@google.com>
20+
Reviewed-by: Roland Shoemaker <roland@golang.org>
21+
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
22+
Auto-Submit: Gopher Robot <gobot@golang.org>
23+
---
24+
vendor/golang.org/x/net/html/token.go | 18 ++++++++++++++++--
25+
1 file changed, 16 insertions(+), 2 deletions(-)
26+
27+
diff --git a/vendor/golang.org/x/net/html/token.go b/vendor/golang.org/x/net/html/token.go
28+
index 3c57880..6598c1f 100644
29+
--- a/vendor/golang.org/x/net/html/token.go
30+
+++ b/vendor/golang.org/x/net/html/token.go
31+
@@ -839,8 +839,22 @@ func (z *Tokenizer) readStartTag() TokenType {
32+
if raw {
33+
z.rawTag = strings.ToLower(string(z.buf[z.data.start:z.data.end]))
34+
}
35+
- // Look for a self-closing token like "<br/>".
36+
- if z.err == nil && z.buf[z.raw.end-2] == '/' {
37+
+ // Look for a self-closing token (e.g. <br/>).
38+
+ //
39+
+ // Originally, we did this by just checking that the last character of the
40+
+ // tag (ignoring the closing bracket) was a solidus (/) character, but this
41+
+ // is not always accurate.
42+
+ //
43+
+ // We need to be careful that we don't misinterpret a non-self-closing tag
44+
+ // as self-closing, as can happen if the tag contains unquoted attribute
45+
+ // values (i.e. <p a=/>).
46+
+ //
47+
+ // To avoid this, we check that the last non-bracket character of the tag
48+
+ // (z.raw.end-2) isn't the same character as the last non-quote character of
49+
+ // the last attribute of the tag (z.pendingAttr[1].end-1), if the tag has
50+
+ // attributes.
51+
+ nAttrs := len(z.attr)
52+
+ if z.err == nil && z.buf[z.raw.end-2] == '/' && (nAttrs == 0 || z.raw.end-2 != z.attr[nAttrs-1][1].end-1) {
53+
return SelfClosingTagToken
54+
}
55+
return StartTagToken
56+
--
57+
2.34.1
58+

0 commit comments

Comments
 (0)