Convert filename filter list to pure ruby

The linuxism of -regextype has broken healthchecks on Solaris and FreeBSD
since 2016

This applies the filters to all the distros and simplifies the code.
Support for regexps on filename suffixes has been dropped in favor of
simplicity and verbosity.

Signed-off-by: Lamont Granquist <[email protected]>

Author: lamont-granquist

lib/omnibus/health_check.rb

@@ -336,15 +336,11 @@ def health_check_aix
     #   the bad libraries (library_name -> dependency_name -> satisfied_lib_path -> count)
     #
     def health_check_ldd
-      regexp_ends = ".*(" + IGNORED_ENDINGS.map { |e| e.gsub(/\./, '\.') }.join("|") + ")$"
-      regexp_patterns = IGNORED_PATTERNS.map { |e| ".*" + e.gsub(%r{/}, '\/') + ".*" }.join("|")
-      regexp = regexp_ends + "|" + regexp_patterns
-
       current_library = nil
       bad_libs = {}
       good_libs = {}
 
-      read_shared_libs("find #{project.install_dir}/ -type f -regextype posix-extended ! -regex '#{regexp}'", "xargs ldd") do |line|
+      read_shared_libs("find #{project.install_dir}/ -type f", "xargs ldd") do |line|
         case line
         when /^(.+):$/
           current_library = Regexp.last_match[1]
@@ -412,14 +408,18 @@ def read_shared_libs(find_command, ldd_command, &output_proc)
       # construct the list of files to check
       #
 
-      find_output = shellout!(find_command).stdout
+      find_output = shellout!(find_command).stdout.lines
+
+      find_output.reject! { |file| IGNORED_ENDINGS.any? { |ending| file.end_with?(ending) } }
+
+      find_output.reject! { |file| IGNORED_SUBSTRINGS.any? { |substr| file.include?(substr) } }
 
       if find_output.empty?
         # probably the find_command is busted, it should never be empty or why are you using omnibus?
         raise "Internal Error: Health Check found no lines"
       end
 
-      if find_output.lines.any? { |file| file !~ Regexp.new(project.install_dir) }
+      if find_output.any? { |file| file !~ Regexp.new(project.install_dir) }
         # every file in the find output should be within the install_dir
         raise "Internal Error: Health Check lines not matching the install_dir"
       end
@@ -429,7 +429,7 @@ def read_shared_libs(find_command, ldd_command, &output_proc)
       #
 
       # this command will typically fail if the last file isn't a valid lib/binary which happens often
-      ldd_output = shellout(ldd_command, input: find_output).stdout
+      ldd_output = shellout(ldd_command, input: find_output.join("\n")).stdout
 
       #
       # do the output process to determine if the files are good or bad

lib/omnibus/whitelist.rb

@@ -1,5 +1,5 @@
 
-# Copyright 2012-2020, Chef Software Inc.
+# Copyright:: Copyright (c) Chef Software Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -181,24 +181,29 @@
 
 IGNORED_ENDINGS = %w{
   .TXT
-  .[ch]
-  .[ch]pp
-  .[eh]rl
   .app
   .appup
   .bat
   .beam
+  .c
   .cc
   .cmake
   .conf
+  .cpp
   .css
-  .e*rb
+  .erb
+  .erl
   .feature
   .gemspec
   .gif
   .gitignore
   .gitkeep
-  .h*h
+  .h
+  .h
+  .hh
+  .hpp
+  .hrl
+  .html
   .jar
   .java
   .jpg
@@ -219,10 +224,13 @@
   .png
   .pod
   .properties
-  .py[oc]*
-  .r*html
+  .py
+  .pyc
+  .pyo
   .rake
+  .rb
   .rdoc
+  .rhtml
   .ri
   .rst
   .scss
@@ -243,7 +251,7 @@
   license
 }.freeze
 
-IGNORED_PATTERNS = %w{
+IGNORED_SUBSTRINGS = %w{
   /build_info/
   /licenses/
   /LICENSES/