Commit dbc425a
nccl: don't panic in Comm::drop when abort returns non-success
A `Drop` impl must never panic. The communicator may already have been
aborted out of band — `Comm::abort` exists precisely to abort a live comm
from another thread to unblock a hung collective — in which case the
abort in `Drop` returns a non-success code. `expect`-ing on it would
panic during unwind/teardown (e.g. while dropping the model that owns the
aborted comm). Ignore the result instead.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 4dff0be commit dbc425a
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
59 | 64 | | |
60 | | - | |
| 65 | + | |
61 | 66 | | |
62 | 67 | | |
63 | 68 | | |
| |||
0 commit comments