Commit dc2f417
nccl: correct Comm thread-safety docs and rename accessor to cu_comm
Drop the SAFETY prose that claimed ncclCommAbort is meant to be called
from another thread while one is blocked inside a collective. Per NCCL's
thread-safety and fault-tolerance docs, a communicator may be operated
from only one thread at a time, and aborting safely requires either that
no thread is in an NCCL op or that the comm was created non-blocking. The
unsafe Send/Sync impls now match the bare style used for the crate's
other opaque handle types (CudaStream, CudaBlas, etc.); Send/Sync only
govern moving/sharing the handle, and operation-ordering remains the
caller's responsibility as elsewhere in the crate.
Rewrite the abort() docs to state that real contract, and rename the raw
handle accessor comm() -> cu_comm() for consistency with cu_stream,
cu_device, cu_ctx, etc.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 63327a2 commit dc2f417
1 file changed
Lines changed: 11 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | 29 | | |
35 | 30 | | |
36 | 31 | | |
| |||
190 | 185 | | |
191 | 186 | | |
192 | 187 | | |
193 | | - | |
| 188 | + | |
194 | 189 | | |
195 | 190 | | |
196 | 191 | | |
197 | 192 | | |
198 | 193 | | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
205 | 204 | | |
206 | 205 | | |
207 | 206 | | |
| |||
0 commit comments