remove chemical_dir_module, make it extension function

Author: wakaztahir

compiler/cbi/bindings/BuildContextCBI.cpp

@@ -46,10 +46,6 @@ LabModule* BuildContextfiles_module(LabBuildContext* self, chem::string_view* sc
     return self->files_module(*scope_name, *name, path, path_len, dependencies->ptr, dependencies->size);
 }
 
-LabModule* BuildContextchemical_dir_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view* path, ModuleSpan* dependencies) {
-    return self->chemical_dir_module(*scope_name, *name, path, dependencies->ptr, dependencies->size);
-}
-
 LabModule* BuildContextc_file_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view* path, ModuleSpan* dependencies) {
     return self->c_file_module(*scope_name, *name, path, dependencies->ptr, dependencies->size);
 }

compiler/cbi/bindings/BuildContextCBI.h

@@ -97,8 +97,6 @@ extern "C" {
 
     LabModule* BuildContextfiles_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view** path, unsigned int path_len, ModuleSpan* dependencies);
 
-    LabModule* BuildContextchemical_dir_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view* path, ModuleSpan* dependencies);
-
     LabModule* BuildContextc_file_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view* path, ModuleSpan* dependencies);
 
     LabModule* BuildContextcpp_file_module(LabBuildContext* self, chem::string_view* scope_name, chem::string_view* name, chem::string_view* path, ModuleSpan* dependencies);

compiler/cbi/bindings/CBI.cpp

@@ -29,7 +29,6 @@ const std::pair<chem::string_view, void*> BuildContextSymMap[] = {
         { "lab_BuildContextadd_path", (void*) BuildContextadd_path },
         { "lab_BuildContextadd_module", (void*) BuildContextadd_module },
         { "lab_BuildContextfiles_module", (void*) BuildContextfiles_module },
-        { "lab_BuildContextchemical_dir_module", (void*) BuildContextchemical_dir_module },
         { "lab_BuildContextc_file_module", (void*) BuildContextc_file_module },
         { "lab_BuildContextcpp_file_module", (void*) BuildContextcpp_file_module },
         { "lab_BuildContextobject_module", (void*) BuildContextobject_module },

compiler/lab/LabBuildContext.h

@@ -277,19 +277,6 @@ class LabBuildContext : public BasicBuildContext {
         return add_with_type(LabModuleType::Directory, scope_name, module_name, nullptr, 0, dependencies, dep_len);
     }
 
-    /**
-     * add the given module as a directory module
-     */
-    LabModule* chemical_dir_module(
-            const chem::string_view& scope_name,
-            const chem::string_view& module_name,
-            chem::string_view* path,
-            LabModule** dependencies,
-            unsigned int dep_len
-    ) {
-        return add_with_type(LabModuleType::Directory, scope_name, module_name, &path, 1, dependencies, dep_len);
-    }
-
     /**
      * add the given module as a c translation unit
      */

lang/libs/lab/src/lab.ch

@@ -120,9 +120,6 @@ public interface BuildContext {
     // support's paths with .o, .c and .ch extensions
     func files_module (&self, scope_name : &std::string_view, name : &std::string_view, paths : **std::string_view, paths_len : uint, dependencies : std::span<*Module>) : *mut Module;
 
-    // directory module
-    func chemical_dir_module (&self, scope_name : &std::string_view, name : &std::string_view, path : &std::string_view, dependencies : std::span<*Module>) : *mut Module
-
     // a single .c file
     func c_file_module (&self, scope_name : &std::string_view, name : &std::string_view, path : &std::string_view, dependencies : std::span<*Module>) : *mut Module
 
@@ -223,6 +220,13 @@ public interface BuildContext {
 
 }
 
+// directory module
+public func (ctx : &BuildContext) chemical_dir_module (scope_name : &std::string_view, name : &std::string_view, path : &std::string_view, dependencies : std::span<*Module>) : *mut Module {
+    const mod = ctx.new_module(scope_name, name, dependencies);
+    ctx.add_path(mod, path);
+    return mod;
+}
+
 public struct ImportSymbol {
     var parts : std::span<std::string_view>;
     var alias : std::string_view;