chore: remove more eslint errors

Author: stropitek

chemistry/structuralAnalysisExercises.js

@@ -43,7 +43,7 @@ async function fetchData(
     }
     let datum = data[file.rn];
     switch (file.kind) {
-      case 'mol':
+      case 'mol': {
         datum.mol = { type: 'mol2d', url: file.url };
         const molfile = await (await fetch(file.url)).text();
         const molecule = Molecule.fromMolfile(molfile);
@@ -61,6 +61,7 @@ async function fetchData(
         datum.nbH = Number(datum.mf.replace(/.*H([0-9]+).*/, '$1'));
         datum.nbC = Number(datum.mf.replace(/.*C([0-9]+).*/, '$1'));
         break;
+      }
       case 'mass':
         datum.mass = { type: 'jcamp', url: file.url };
         datum.isMass = true;

defaultOptions/mass.js

@@ -1,4 +1,4 @@
-define(function () {
+define(() => {
   return {
     monoisotopicMass: 300.123,
     resolution: 100000,

eln/BioReaction.js

@@ -177,10 +177,11 @@ class BioReaction {
       case 'save':
         await this.roc.update(this.sample);
         break;
-      case 'deleteAttachment':
-        var attachment = action.value.name;
+      case 'deleteAttachment': {
+        const attachment = action.value.name;
         await this.roc.deleteAttachment(this.sample, attachment);
         break;
+      }
       case 'unattach':
         await this.roc.unattach(this.sample, action.value);
         break;

eln/ExtSample.js

@@ -100,7 +100,7 @@ class Sample {
         case '$content.general.mf':
           try {
             this.mf.fromMF();
-          } catch (e) {
+          } catch {
             // ignore
           }
           break;
@@ -119,7 +119,7 @@ class Sample {
   }
 
   async _init() {
-    this._initialized = new Promise(async (resolve) => {
+    this._initialized = (async () => {
       let sample;
       if (this.options.trackId) {
         try {
@@ -143,8 +143,7 @@ class Sample {
         sample.$content.general.molfile = ''; // can not be edited otherwise
       }
       this._loadSample(sample);
-      resolve();
-    });
+    })();
   }
 
   bindChange() {
@@ -157,7 +156,7 @@ class Sample {
   }
 
   async handleDrop(name, askType, options = {}) {
-    let { converters = {}, autoJcamp, autoKind } = options;
+    let { converters = {}, autoKind } = options;
     if (!name) {
       throw new Error('handleDrop expects a variable name');
     }
@@ -201,8 +200,6 @@ class Sample {
       }
 
       if (converters[kind]) {
-        autoJcamp = false;
-
         let converted = await converters[kind](droppedData.content);
         if (!Array.isArray(converted)) {
           converted = [converted];

eln/MF.js

@@ -97,10 +97,6 @@ class MF {
     this.sample.setChildSync(['$content', 'general', 'mf'], mf);
   }
 
-  setMF(mf) {
-    this.sample.setChildSync(['$content', 'general', 'mf'], mf);
-  }
-
   setMW(mw) {
     this.sample.setChildSync(['$content', 'general', 'mw'], mw);
   }

eln/Nmr1dManager.js

@@ -177,13 +177,14 @@ class Nmr1dManager {
         this._autoRanges(currentNmr);
         break;
       }
-      case 'deleteAllRanges':
-        var ranges = API.getData('currentNmrRanges');
+      case 'deleteAllRanges': {
+        const ranges = API.getData('currentNmrRanges');
         while (ranges.length) {
           ranges.pop();
         }
         ranges.triggerChange();
         break;
+      }
       case 'clearAssignments': {
         let ranges = this.getCurrentRanges();
         if (ranges) {
@@ -298,8 +299,9 @@ class Nmr1dManager {
   _getNMR(currentNMRLine) {
     let filename = String(currentNMRLine.getChildSync(['jcamp', 'filename']));
     return currentNMRLine.getChild(['jcamp', 'data']).then((jcamp) => {
+      let spectrum;
       if (filename && this.spectra[filename]) {
-        var spectrum = this.spectra[filename];
+        spectrum = this.spectra[filename];
       } else if (jcamp) {
         jcamp = String(jcamp.get());
         spectrum = NMR.fromJcamp(jcamp);
@@ -381,7 +383,7 @@ class Nmr1dManager {
         if (mfInfo && mfInfo.atoms && mfInfo.atoms.H) {
           return mfInfo.atoms.H || 100;
         }
-      } catch (e) {
+      } catch {
         return 100;
       }
     }

eln/Sample.js

@@ -616,11 +616,15 @@ Your local changes will be lost.</p>`;
                 content = atob(droppedData.content);
                 droppedData.encoding = 'text';
                 break;
-              case 'buffer':
+              case 'buffer': {
                 const decoder = new TextDecoder();
                 content = decoder.decode(droppedData.content);
                 droppedData.encoding = 'text';
                 break;
+              }
+              default: {
+                // No special handling
+              }
             }
             droppedData.content = convertToJcamp(content, {
               meta,
@@ -675,8 +679,8 @@ Your local changes will be lost.</p>`;
       case 'translateNucleic':
         Sequence.translateNucleic(this.sample);
         break;
-      case 'createOptions':
-        var advancedOptions1H = API.cache('nmr1hAdvancedOptions');
+      case 'createOptions': {
+        const advancedOptions1H = API.cache('nmr1hAdvancedOptions');
         if (advancedOptions1H) {
           API.createData(
             'nmr1hOndeTemplate',
@@ -689,8 +693,10 @@ Your local changes will be lost.</p>`;
           );
         }
         break;
+      }
       case 'recreateVariables':
         this.createVariables();
+        break;
       case 'deleteAttachment': {
         const ok = await UI.confirm(
           'Are you sure you want to delete the attachment?',

eln/StockSample.js

@@ -56,7 +56,7 @@ class Sample {
         case '$content.general.mf':
           try {
             this.mf.fromMF();
-          } catch (e) {
+          } catch {
             // ignore
           }
           break;
@@ -69,11 +69,10 @@ class Sample {
   }
 
   async _init() {
-    this._initialized = new Promise(async (resolve) => {
+    this._initialized = (async () => {
       this.sample = await API.createData(this.options.varName, this.sample);
       this._loadSample();
-      resolve();
-    });
+    })();
   }
 
   bindChange() {

eln/nucleic/genbank.js

@@ -1,7 +1,8 @@
-import Twig from 'lib/twigjs/twig';
+// eslint-disable-next-line import/no-unassigned-import
 import 'angularplasmid';
-import typerenderer from 'src/util/typerenderer';
 import $ from 'jquery';
+import Twig from 'lib/twigjs/twig';
+import typerenderer from 'src/util/typerenderer';
 
 const templateOptions = {
   style: `
@@ -86,9 +87,9 @@ export async function getSvg(parsedGb, options) {
 }
 
 async function compile(val) {
-  return new Promise(function (resolve) {
+  return new Promise(function compile(resolve) {
     let $injector = self.angular.injector(['ng', 'angularplasmid']);
-    $injector.invoke(function ($rootScope, $compile) {
+    $injector.invoke(function invoke($rootScope, $compile) {
       const svg = $compile(String(val))($rootScope);
       // TODO: why is this setTimeout needed
       setTimeout(() => resolve(svg), 0);