Skip to content

Commit 008301e

Browse files
committed
docs(requestcontrol): correct FlowControlAdmissionController.Admit docstring
The docstring for FlowControlAdmissionController.Admit previously claimed that it checked for saturation on sheddable requests first, then deferred to Flow Control. This was incorrect; the implementation only defers via EnqueueAndWait, and saturation shedding is handled downstream by the dispatch cycle. Update the docstring to accurately describe the implemented behavior. No runtime changes are made. Fixes llm-d#1934 Signed-off-by: ChethanUK <chethanuk@outlook.com>
1 parent bcbca9a commit 008301e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

pkg/epp/requestcontrol/admission.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,8 +145,8 @@ func NewFlowControlAdmissionController(fc flowController, poolName string) *Flow
145145
}
146146
}
147147

148-
// Admit implements the AdmissionController interface by checking for saturation on sheddable requests first, then
149-
// deferring to the Flow Control system.
148+
// Admit defers the admission decision to the Flow Control system via EnqueueAndWait; saturation-based shedding
149+
// of sheddable requests is handled downstream by the dispatch cycle, not at admission.
150150
func (fcac *FlowControlAdmissionController) Admit(
151151
ctx context.Context,
152152
reqCtx *handlers.RequestContext,

0 commit comments

Comments
 (0)