Skip to content

Symlink doesn't get created #252

Description

@lukebitts

I'm working locally on two projects: "game" and "addon1".

On the "game" side, I've declared the addons.jsonc file like this:

"addons": {
    "addon1": { // name must match the folder name in the repository
      "url": "../addons/addon1",
      "source": "symlink",
      // "checkout": "main", // default
      "subfolder": "addons/addon1"
    }
  }

This does not work. When running godotenv addons install I get an empty "addon1" folder, not a symlink.

To fix this I had to edit the AddonsRepository.cs file, line 373:
From:
FileClient.CreateSymlink(symlinkTarget, symlinkSource);
To:
FileClient.CreateSymlink(symlinkTarget, symlinkSource).GetAwaiter().GetResult();

Since CreateSymlink returns a Task that is not awaited, the GodotEnv application finishes before the symlink is created.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions