Skip to content

Dependencies don't seem to be included correctly in symlink mode #253

Description

@lukebitts

After fixing the issue reported here #252 I came across another problem:

I have three projects: "game", "addon1" and "addon2". "game" declares a dependency on "addon1" and "addon1" declares a dependency on "addon2". Running godotenv addons install on the "game" project only installs the "addon1".

This happens because the CacheAddon method in the AddonsRepository.cs file (line 164) returns the combined path+subfolder, but the addons.jsonc file on the "addon2" lives in the path, not the subfolder.

Locally I've fixed it by simply doing return addon.Url; when addon.IsSymlink == true instead of return FileClient.Combine(addon.Url,addon.Subfolder.TrimEnd(FileClient.Separator));

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions