wrote calculate_velocity_metrics#100
Conversation
|
need to discuss how we are going to handle divide by 0 @Asanto32 take a peek at this function and lmk how you think this should be handled. The current implementation is based off https://github.com/theBasicScientist/trailsab-proc |
|
Need to write unit tests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 98.57% 98.59% +0.01%
==========================================
Files 19 19
Lines 1054 1067 +13
==========================================
+ Hits 1039 1052 +13
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
have a raise error that there is a double time value and that shouldnt happen for divide by 0 |
…ons-calculate_segment_velocity_metrics
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Take a look at tthe comments on the tests. Specifically the use of approx values
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
lgtm, small comment about the var >0.0 assert
cgmaiorano
deleted the
96-task-write-trails-velocity-feature-functions-calculate_segment_velocity_metrics
branch
2 participants
#96 wrote function to calculate all velocity metrics on a per LineSegment basis. Calculates and assigns velocities, distance, mean_speed, speed_variance, and accelerations to the LineSegment class.