102 task add GridCell model#119
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 98.57% 98.63% +0.05%
==========================================
Files 19 19
Lines 1054 1097 +43
==========================================
+ Hits 1039 1082 +43
Misses 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Asanto32
reviewed
Feb 17, 2026
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Some small edge cases to think about + use of pydantic basemodel instead of dataclass?
… that the outer grid boundaries will be padded at the Grid level.
Asanto32
approved these changes
Feb 25, 2026
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Minor discrepancy between test docstring and actual test, otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #102
This PR introduces GridCell model and unit tests for them to assign strokes based on centroid location, used for DSYM and Alphabet tasks.
Grid cells use half-open intervals [min, max) to avoid double-assignment on shared boundaries. The last cell in each dimension is fully inclusive [min, max].