Skip to content

feature/issue-17/implement-time-features#18

Merged
alperkent merged 1 commit into
mainfrom
alperkent/issue17
Apr 22, 2025
Merged

feature/issue-17/implement-time-features#18
alperkent merged 1 commit into
mainfrom
alperkent/issue17

Conversation

@alperkent
Copy link
Copy Markdown
Collaborator

Resolves #17.

@alperkent alperkent added enhancement New feature or request task A development task intended for Github Projects labels Apr 18, 2025
@alperkent alperkent requested a review from Asanto32 April 18, 2025 18:27
@alperkent alperkent self-assigned this Apr 18, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (9570fda) to head (dfb5e89).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/graphomotor/features/time.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #18      +/-   ##
===========================================
- Coverage   100.00%   97.45%   -2.55%     
===========================================
  Files            4        5       +1     
  Lines          115      118       +3     
===========================================
  Hits           115      115              
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@Asanto32 Asanto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're losing your 100% codevcoverage ;) but this is good with me. Presumably this will be covered in a future test any with the orchestrator.

@alperkent alperkent merged commit cebeeb0 into main Apr 22, 2025
16 checks passed
@alperkent alperkent deleted the alperkent/issue17 branch April 22, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request task A development task intended for Github Projects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Implement time.py module, computation of temporal features

2 participants