feature/issue-23/implement-orchestrator#27
Merged
Conversation
…FeatureCategories class, edit all related modules to use the new spiral config class properly, add tests for customizing spiral config, and add smoke test for orchestrator
- Modified center_spiral.py so that it can be used to center reference spiral as well, and added unit tests. - Renamed the unit test script for reference spiral module to match the module name. - Replaced the sample data file with a more realistic one. - Added a perfect spiral with 3000 points to the sample data folder to use for testing the center_spiral function. - Removed the center_spiral call from velocity.py since the spiral is now centered in the orchestratior. - Changed the name of the class method for SpiralConfig and modified relevant calls. - Refactored orchestrator to refine output formatting.
…ance CSV export logging and error handling; add unit tests, edit velocity metrics unit test to fix centering changes.
alperkent
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
===========================================
+ Coverage 98.24% 100.00% +1.75%
===========================================
Files 9 10 +1
Lines 171 296 +125
===========================================
+ Hits 168 296 +128
+ Misses 3 0 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…error handling for invalid inputs
Asanto32
reviewed
May 20, 2025
Collaborator
Asanto32
left a comment
Asanto32
left a comment
There was a problem hiding this comment.
Looks pretty good. The major thing is to fix the unit tests to avoid all the logic branching. The test becomes quite convoluted and then it is no longer clear what unit of code it is testing
…strator.py, and break up tests to avoid logic branching
…efault values for output_path and feature_categories
…g_params` argument of `run_pipeline`; update imports across multiple modules for consistency of importing only at module-level.
Asanto32
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #23 with various other improvements.