Skip to content

69 task write trails time feature functions error time#95

Merged
cgmaiorano merged 6 commits into
mainfrom
69-task-write-trails-time-feature-functions-error_time
Feb 9, 2026
Merged

69 task write trails time feature functions error time#95
cgmaiorano merged 6 commits into
mainfrom
69-task-write-trails-time-feature-functions-error_time

Conversation

@cgmaiorano
Copy link
Copy Markdown
Collaborator

This function calculates the total time spent making errors. It will take in the entire dataframe, check when there is an error based on the "error" column, and sum the total time spent making errors.

@cgmaiorano cgmaiorano linked an issue Dec 9, 2025 that may be closed by this pull request
6 tasks
@cgmaiorano cgmaiorano marked this pull request as ready for review December 9, 2025 18:35
@cgmaiorano cgmaiorano requested review from Asanto32, Copilot and kimit0310 and removed request for Copilot December 9, 2025 18:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.57%. Comparing base (59caf4e) to head (4783230).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   98.49%   98.57%   +0.07%     
==========================================
  Files          18       19       +1     
  Lines         998     1054      +56     
==========================================
+ Hits          983     1039      +56     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/graphomotor/features/trails/time.py
@cgmaiorano cgmaiorano requested a review from Asanto32 January 19, 2026 18:45
Copy link
Copy Markdown
Collaborator

@Asanto32 Asanto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this works and you seem to cover all the cases, just maybe some stylistic changes/suggestions to improve the readability of the function

Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
Comment thread src/graphomotor/features/trails/time.py Outdated
@cgmaiorano cgmaiorano requested a review from Asanto32 February 5, 2026 15:49
Copy link
Copy Markdown
Collaborator

@Asanto32 Asanto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go mets

Comment thread src/graphomotor/features/trails/time.py Outdated
@cgmaiorano cgmaiorano merged commit da2c270 into main Feb 9, 2026
26 checks passed
@cgmaiorano cgmaiorano deleted the 69-task-write-trails-time-feature-functions-error_time branch February 9, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Write Trails Time Feature functions: error_time

2 participants