Skip to content

Commit 3735e06

Browse files
committed
Merge main and address PR #267 review feedback
- Resolve merge conflicts (keep orchestration layer, discard old inline logic) - Fix docstring paths in generate_bids_tools.py (#1) - Remove redundant extension=Extension.NII_GZ in longitudinal export (#5) - Clarify verbose docstring in RunnerConfig (#6)
2 parents d3dc505 + bd9c68d commit 3735e06

3 files changed

Lines changed: 4 additions & 5 deletions

File tree

scripts/generate_bids_tools.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"""Generate BIDS schema constants, utilities, and tests for the rbc package.
66
77
Reads the BIDS schema via bidsschematools and generates:
8-
- src/rbc/core/bids/_schema.py (constants + build/parse functions)
9-
- tests/unit/test_bids.py (unit tests)
8+
- src/rbc/bids/_schema.py (constants + build/parse functions)
9+
- tests/unit/bids/test_bids.py (unit tests)
1010
1111
Run with:
1212
uv run scripts/generate_bids_tools.py

src/rbc/bids/longitudinal.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from typing import TYPE_CHECKING
66

7-
from rbc.bids import Extension, Suffix
7+
from rbc.bids import Suffix
88

99
if TYPE_CHECKING:
1010
from pathlib import Path
@@ -157,7 +157,6 @@ def export_longitudinal_func(fex: Bids, outputs: FunctionalLongOutputs) -> None:
157157
outputs.forward_xfm,
158158
suffix="xfm",
159159
desc="composite",
160-
extension=Extension.NII_GZ,
161160
extra={"from": "bold", "to": "longitudinal", "mode": "image"},
162161
)
163162
if outputs.bold_mask:

src/rbc/orchestration/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class RunnerConfig:
4646
4747
Attributes:
4848
runner: Execution backend (local, docker, podman, singularity).
49-
verbose: Verbosity level.
49+
verbose: Enable verbose output (progress bars, info logging).
5050
tmp_dir: Temporary directory for intermediate files.
5151
"""
5252

0 commit comments

Comments
 (0)