Skip to content

Single subject anatomical workflow#35

Merged
nx10 merged 14 commits into
mainfrom
enh/anatomical
Feb 6, 2026
Merged

Single subject anatomical workflow#35
nx10 merged 14 commits into
mainfrom
enh/anatomical

Conversation

@kaitj
Copy link
Copy Markdown
Contributor

@kaitj kaitj commented Feb 2, 2026

Duplicate of #6, that got closed automatically when trying to fix lfs (and couldn't reopen).

First implementation of workflow with modular pieces of RBC anatomical / structural.

cc: @jpillai00

@kaitj kaitj self-assigned this Feb 2, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 29.50820% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.50%. Comparing base (81ce9e3) to head (dc61903).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/rbc/core/anatomical/registration.py 0.00% 10 Missing ⚠️
src/rbc/core/anatomical/segmentation.py 0.00% 10 Missing ⚠️
src/rbc/core/common.py 0.00% 8 Missing ⚠️
src/rbc/core/resources/__init__.py 0.00% 8 Missing ⚠️
src/rbc/core/utils.py 80.95% 4 Missing ⚠️
src/rbc/core/anatomical/__init__.py 0.00% 3 Missing ⚠️

❌ Your project status has failed because the head coverage (29.50%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##              main      #35       +/-   ##
============================================
- Coverage   100.00%   29.50%   -70.50%     
============================================
  Files            1        7        +6     
  Lines           10       61       +51     
============================================
+ Hits            10       18        +8     
- Misses           0       43       +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaitj kaitj force-pushed the enh/anatomical branch 5 times, most recently from 0e9f0c2 to 72cc479 Compare February 3, 2026 21:59
uses: ./.github/actions/setup-venv
- name: Run quick tests
id: run-quick-tests
shell: bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure this is default

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would think so, but without it the windows runs fail.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah because of the linebreaks with \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switching to no linebreaks is probably better than emulating bash on windows

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or alternatively run just pytest without coverage there - dont think we need multi platform cov

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think i'll probably address this workflow in a separate PR. At least for now this works and gives us some tests, but definitely want to change it up.

kaitj added 2 commits February 5, 2026 16:23
- Rename skull_stripping.py -> segmentation.py
- Added FSL Fast segmentation to anatomical workflow
@kaitj kaitj requested a review from nx10 February 5, 2026 21:27
@kaitj kaitj marked this pull request as ready for review February 5, 2026 21:27
@kaitj
Copy link
Copy Markdown
Contributor Author

kaitj commented Feb 5, 2026

This one is pretty much good to go from a workflow standpoint (will add tests in a separate PR just to get this pushed in for now).

I am just waiting for the local e2e test to finish.

@kaitj
Copy link
Copy Markdown
Contributor Author

kaitj commented Feb 5, 2026

Also just updated the dependencies in a separate commit (for easy rollback) to satisfy the deptry check.

@nx10
Copy link
Copy Markdown
Contributor

nx10 commented Feb 6, 2026

Merging for now to be able to base other PRs testing on this structure - subsequent PRs should improve CI and documentation

@nx10 nx10 merged commit 56dfd40 into main Feb 6, 2026
7 of 8 checks passed
@nx10 nx10 deleted the enh/anatomical branch February 6, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants