Skip to content

Commit e204345

Browse files
authored
fix(log error): handle undefined target when websocket errors (#527)
1 parent 455ba47 commit e204345

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
## next
44

5-
- feat(handler): response interceptor
5+
- feat(handler): response interceptor ([#520](https://github.com/chimurai/http-proxy-middleware/pull/520))
6+
- fix(log error): handle undefined target when websocket errors ([#527](https://github.com/chimurai/http-proxy-middleware/pull/527))
67

78
## [v1.1.2](https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.1.2)
89

src/http-proxy-middleware.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,10 @@ export class HttpProxyMiddleware {
183183
}
184184
};
185185

186-
private logError = (err, req: Request, res: Response, target) => {
186+
private logError = (err, req: Request, res: Response, target?) => {
187187
const hostname = req.headers?.host || req.hostname || req.host; // (websocket) || (node0.10 || node 4/5)
188188
const requestHref = `${hostname}${req.url}`;
189-
const targetHref = `${target.href}`;
189+
const targetHref = `${target?.href}`; // target is undefined when websocket errors
190190

191191
const errorMessage = '[HPM] Error occurred while proxying request %s to %s [%s] (%s)';
192192
const errReference = 'https://nodejs.org/api/errors.html#errors_common_system_errors'; // link to Node Common Systems Errors page

0 commit comments

Comments
 (0)