update questionIds to work with different environments

Author: cherylli

src/global/constants/questionIds.ts

@@ -1,8 +1,24 @@
-export const questionIds = {
-    userApplication: {
-        firstname: 53,
-        lastname: 52,
-        countryCode: 50,
-        gender: 51,
+// use MJ_ENV since we need the same env: local, dev, prod
+// dev questionIds are unknown as they don't currently exist,
+// it will probably be the same since they seed from the same set of data
+const questionIdsSets = {
+    local: {
+        userApplication: {
+            firstname: 53,
+            lastname: 52,
+            countryCode: 50,
+            gender: 51,
+        },
+    },
+    dev: {
+        userApplication: {
+            firstname: 53,
+            lastname: 52,
+            countryCode: 50,
+            gender: 51,
+        },
     },
 };
+
+const MJ_ENV = process.env.MJ_ENV === "local" ? "local" : "dev";
+export const questionIds = questionIdsSets[MJ_ENV];

src/users/users.service.ts

@@ -342,9 +342,5 @@ export class UsersService {
                 throw e;
             }
         }
-
-        // TODO: return the entity (maybe just the fields updated) but without sensitive information like the admin comments
-
-        // return `User application submitted, ${req.user.userId}, firstname=${firstname}, lastname=${lastname}, countryCode=${countryCode}`;
     }
 }