Skip to content

Commit 7060d97

Browse files
committed
(#153) Skip signing verification on PR build
The new verify signing task was running on PR builds, which was causing the PR build to fail when there were signatures that were invalid. This stops the flow of doing additional testing on the PR builds, as the arfifacts would not have been created. We should skip the verification when running on a PR build (or when on a non-releaseable branch), that way, the additional task of performing the re-signing can be completed as a follow up piece of work.
1 parent 892c826 commit 7060d97

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Chocolatey.Cake.Recipe/Content/sign.cake

+2
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@
1515

1616
BuildParameters.Tasks.VerifyPowerShellScriptsTask = Task("Verify-PowerShellScripts")
1717
.WithCriteria(() => BuildParameters.BuildAgentOperatingSystem == PlatformFamily.Windows, "Skipping due to not running on Windows")
18+
.WithCriteria(() => !BuildParameters.IsPullRequest, "Skipping because current build is from a Pull Request")
19+
.WithCriteria(() => BuildParameters.BranchType == BranchType.Master || BuildParameters.BranchType == BranchType.Release || BuildParameters.BranchType == BranchType.HotFix, "Skipping because this is not a releasable branch")
1820
.WithCriteria(() => BuildParameters.ShouldVerifyPowerShellScripts, "Skipping since verifying PowerShell scripts has been disabled")
1921
.Does(() =>
2022
{

0 commit comments

Comments
 (0)