You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new verify signing task was running on PR builds, which was causing
the PR build to fail when there were signatures that were invalid.
This stops the flow of doing additional testing on the PR builds, as the
arfifacts would not have been created.
We should skip the verification when running on a PR build (or when on a
non-releaseable branch), that way, the additional task of performing
the re-signing can be completed as a follow up piece of work.
.WithCriteria(()=>BuildParameters.BuildAgentOperatingSystem==PlatformFamily.Windows,"Skipping due to not running on Windows")
18
+
.WithCriteria(()=>!BuildParameters.IsPullRequest,"Skipping because current build is from a Pull Request")
19
+
.WithCriteria(()=>BuildParameters.BranchType==BranchType.Master||BuildParameters.BranchType==BranchType.Release||BuildParameters.BranchType==BranchType.HotFix,"Skipping because this is not a releasable branch")
18
20
.WithCriteria(()=>BuildParameters.ShouldVerifyPowerShellScripts,"Skipping since verifying PowerShell scripts has been disabled")
0 commit comments