Code cleaning: ChocoDIMACS, ChocoMPS and some parts of MiniSat

[cprudhom]

I am considering removing ChocoDIMACS and ChocoMPS (neither of which, as far as I know, is used) and also removing anything in MiniSat that is not related to LCG (that is, use the MiniSat solver directly without going through Choco.)
Any complaints?

[jgFages]

Isn't it used through Choco Solver when using model.addclauseXXX even if LCG is off ?

[cprudhom]

I probably should have taken more time to expose my point.
Currently, one can use the embedded sat solver with or without LCG.
That's transparent from its pov.
One can also call the sat solver directly. In that case, he can enter a sat formula or a DIMACS file and check for its satisfiability.
My point here is that if someone needs a sat solver, he should certainly use a dedicated one, there are plenty of them, up to date.

So I suggest to prevent the direct usage of the sat solver and clean up the code (remove the parser, the modeler, the search function, etc).
That would make the code easier to maintain and read.

[jgFages]

Thanks for the explanation. Sure it seems fine to me to remove it and reduce the code base