Skip to content

Commit e38a577

Browse files
committed
shift a docstring
1 parent 0687ebf commit e38a577

2 files changed

Lines changed: 31 additions & 34 deletions

File tree

src/cooling/cool_components.h

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,37 @@
1616
*/
1717
/** @{ */
1818

19+
/*! \brief Describes cooling components
20+
*
21+
* \note Maybe we should call this namespace edot_component? (Since there's heating & cooling)
22+
*
23+
* Each cooling recipe is composed of one or more cooling components. A cooling
24+
* component is a "callable" (i.e. it's a function or it's a class that implements
25+
* the appropriate method that let's be called just like a function).
26+
*
27+
* Optimization Notes
28+
* ==================
29+
* It's important that that "core-logic" of each cooling component is implemented in a
30+
* header file or in the same source file where a recipe actually invokes the
31+
* "core logic". The "core-logic" includes code paths accessible through function-call
32+
* syntax. To be more explicit,
33+
* - when a cool-component is a regular function, the "core-logic" includes the whole
34+
* function itself and any (user-defined) functions called by that function
35+
* - for a callable class, the "core-logic" includes the definition of the
36+
* `Real operator()(args...)` member function and any (user-defined) functions
37+
* called by that member-function
38+
*
39+
* We may also want to consider using ``__forceinline__``. With that said, we should
40+
* only use ``__forceinline__`` if it explicitly provides a performance improvement
41+
* (blindly using ``__forceinline__`` can actually hurt performance)
42+
*
43+
* In the future, if most heating and cooling contributiond need ``log10(n)`` and
44+
* ``log10(T)``, we may want to consider pre-computing those values. In this scenario,
45+
* we probably want to continue providing ``n`` and ``T``. This could potentially
46+
* improve performance in recipies using multiple independent contributions since
47+
* ``log10`` and ``pow`` are generally a lot more expensive than most other operations
48+
* relevant for computing heating and cooling
49+
*/
1950
namespace cool_component
2051
{
2152

src/cooling/load_cloudy_texture.h

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -11,40 +11,6 @@
1111
#include "../io/ParameterMap.h"
1212
#include "../utils/shared.h"
1313

14-
/*! \brief Describes cooling components
15-
*
16-
* \todo if we create a file that holds all non-tabulated cool-components, we may want
17-
* to move this docstring to that file
18-
*
19-
* \note Maybe we should call this namespace edot_component? (Since there's heating & cooling)
20-
*
21-
* Each cooling recipe is composed of one or more cooling components. A cooling
22-
* component is a "callable" (i.e. it's a function or it's a class that implements
23-
* the appropriate method that let's be called just like a function).
24-
*
25-
* Optimization Notes
26-
* ==================
27-
* It's important that that "core-logic" of each cooling component is implemented in a
28-
* header file or in the same source file where a recipe actually invokes the
29-
* "core logic". The "core-logic" includes code paths accessible through function-call
30-
* syntax. To be more explicit,
31-
* - when a cool-component is a regular function, the "core-logic" includes the whole
32-
* function itself and any (user-defined) functions called by that function
33-
* - for a callable class, the "core-logic" includes the definition of the
34-
* `Real operator()(args...)` member function and any (user-defined) functions
35-
* called by that member-function
36-
*
37-
* We may also want to consider using ``__forceinline__``. With that said, we should
38-
* only use ``__forceinline__`` if it explicitly provides a performance improvement
39-
* (blindly using ``__forceinline__`` can actually hurt performance)
40-
*
41-
* In the future, if most heating and cooling contributiond need ``log10(n)`` and
42-
* ``log10(T)``, we may want to consider pre-computing those values. In this scenario,
43-
* we probably want to continue providing ``n`` and ``T``. This could potentially
44-
* improve performance in recipies using multiple independent contributions since
45-
* ``log10`` and ``pow`` are generally a lot more expensive than most other operations
46-
* relevant for computing heating and cooling
47-
*/
4814
namespace cool_component
4915
{
5016

0 commit comments

Comments
 (0)