Merge pull request #48 from choria-io/340

(#340) Improve required flag missing error, now show all missing flags

Author: ripienaar

Diff for: app.go

@@ -715,15 +715,23 @@ func (a *Application) validateRequired(context *ParseContext) error {
 	}
 
 	// Check required flags and set defaults.
+	var neededFlags []string
 	for _, flag := range context.flags.long {
 		if flagElements[flag.name] == nil {
 			// Check required flags were provided.
 			if flag.needsValue() {
-				return fmt.Errorf("%w --%s not provided", ErrRequiredFlag, flag.name)
+				neededFlags = append(neededFlags, fmt.Sprintf("--%s", flag.name))
 			}
 		}
 	}
 
+	switch {
+	case len(neededFlags) == 1:
+		return fmt.Errorf("%w %s not provided", ErrRequiredFlag, neededFlags[0])
+	case len(neededFlags) > 1:
+		return fmt.Errorf("%ws %s not provided", ErrRequiredFlag, strings.Join(neededFlags, ", "))
+	}
+
 	for _, arg := range context.arguments.args {
 		if argElements[arg.name] == nil {
 			if arg.needsValue() {