Why not "break"?

[d-a-gerashenko]

php-resque/lib/Resque.php

Line 307 in 968b7e6

$finished = true;

php-resque/lib/Resque.php

Line 298 in 968b7e6

$finished = true;

Isn't "break" more appropriate than "$finished" variable?

[danhunsaker]

Even better than while(true) and break; would be to move the $string = lines into the while() condition, and remove the if checks entirely. I'd accept a PR at the new repo (https://github.com/resque/php-resque) to apply this change.

I'm assuming it was a stylistic choice to write it the current way in the original PR that added this function.