chore: formatting, minor cleanup

Author: chrisgrieser

scripts/github-notifications.js

@@ -80,7 +80,8 @@ function run() {
 		});
 	}
 
-	// CALL GITHUB API https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#list-notifications-for-the-authenticated-user
+	// CALL GITHUB API 
+	// DOCS https://docs.github.com/en/rest/activity/notifications?apiVersion=2022-11-28#list-notifications-for-the-authenticated-user
 	const parameter = showReadNotifs ? "?all=true" : "";
 	const response = httpRequestWithHeaders("https://api.github.com/notifications" + parameter, [
 		"Accept: application/vnd.github.v3+json",

scripts/public-github-repo-search.js

@@ -65,13 +65,16 @@ function run(argv) {
 		return JSON.stringify({ items: [{ title: "Waiting for query…", valid: false }] });
 	}
 
+	// DOCS https://docs.github.com/en/rest/search/search?apiVersion=2022-11-28#search-repositories
+	const apiURL = `https://api.github.com/search/repositories?q=${encodeURIComponent(query)}`;
+	const response = JSON.parse(httpRequest(apiURL));
+
 	const forkOnClone = $.getenv("fork_on_clone") === "1";
 	const depthInfo = $.getenv("clone_depth") ? ` (depth ${$.getenv("clone_depth")})` : "";
-	const apiURL = `https://api.github.com/search/repositories?q=${encodeURIComponent(query)}`;
 
 	/** @type {AlfredItem[]} */
-	const repos = JSON.parse(httpRequest(apiURL))
-		.items.filter((/** @type {GithubRepo} */ repo) => !(repo.fork || repo.archived))
+	const repos = response.items
+		.filter((/** @type {GithubRepo} */ repo) => !(repo.fork || repo.archived))
 		.map((/** @type {GithubRepo} */ repo) => {
 			// calculate relative date
 			// INFO pushed_at refers to commits only https://github.com/orgs/community/discussions/24442
@@ -83,7 +86,9 @@ function run(argv) {
 				"★ " + repo.stargazers_count,
 				lastUpdated,
 				repo.description,
-			].join("  ·  ");
+			]
+				.filter(Boolean)
+				.join("  ·  ");
 
 			const cloneSubtitle = "⌃: Shallow Clone " + depthInfo + (forkOnClone ? " & Fork" : "");
 			const secondUrl = repo.homepage || repo.html_url + "/releases";
@@ -110,6 +115,7 @@ function run(argv) {
 			};
 		});
 
+	// GUARD no results
 	if (repos.length === 0) {
 		repos.push({
 			title: "🚫 No results",

scripts/public-issue-search.js

@@ -1,13 +1,13 @@
 #!/usr/bin/env osascript -l JavaScript
 ObjC.import("stdlib");
-ObjC.import("Foundation");
 const app = Application.currentApplication();
 app.includeStandardAdditions = true;
+//──────────────────────────────────────────────────────────────────────────────
 
 function alfredMatcher(str) {
 	const clean = str.replace(/[-()_.:#]/g, " ");
-	const camelCaseSeperated = str.replace(/([A-Z])/g, " $1");
-	return [clean, camelCaseSeperated, str].join(" ");
+	const camelCaseSeparated = str.replace(/([A-Z])/g, " $1");
+	return [clean, camelCaseSeparated, str].join(" ");
 }
 
 //──────────────────────────────────────────────────────────────────────────────
@@ -17,20 +17,16 @@ const repoID = $.getenv("repoID");
 
 // get plugin issues
 const issueAPIURL =
-	"https://api.github.com/repos/" + repoID
-	+ "/issues?state=all"
-	+ "&per_page=100"; // GitHub API only returns 100 results https://stackoverflow.com/questions/30656761/github-search-api-only-return-30-results
+	"https://api.github.com/repos/" + repoID + "/issues?state=all" + "&per_page=100"; // GitHub API only returns 100 results https://stackoverflow.com/questions/30656761/github-search-api-only-return-30-results
 console.log(issueAPIURL);
-const issueJSON =
-	JSON.parse(app.doShellScript("curl -s \"" + issueAPIURL + "\""))
-		.sort((x, y) => {
-			const a = x.state;
-			const b = y.state;
-			return a === b ? 0 : a < b ? 1 : -1; // eslint-disable-line no-nested-ternary
-		});
+const issueJSON = JSON.parse(app.doShellScript('curl -s "' + issueAPIURL + '"')).sort((x, y) => {
+	const a = x.state;
+	const b = y.state;
+	return a === b ? 0 : a < b ? 1 : -1; // eslint-disable-line no-nested-ternary
+});
 
 // existing issues
-issueJSON.forEach(issue => {
+issueJSON.forEach((issue) => {
 	const title = issue.title;
 	const issueCreator = issue.user.login;
 
@@ -52,10 +48,10 @@ issueJSON.forEach(issue => {
 	].join(" ");
 
 	jsonArray.push({
-		"title": state + title,
-		"match": issueMatcher,
-		"subtitle": "#" + issue.number + " by " + issueCreator + comments,
-		"arg": issue.html_url,
+		title: state + title,
+		match: issueMatcher,
+		subtitle: "#" + issue.number + " by " + issueCreator + comments,
+		arg: issue.html_url,
 	});
 });