Skip to content

Commit 88eece7

Browse files
chrisguidryclaude
andcommitted
Say "quietly dropped" instead of "silently dropped" for admission control
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 3d3312f commit 88eece7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

docs/task-behaviors.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ async def monitor_concurrency_usage() -> None:
423423

424424
## Cooldown
425425

426-
Cooldown executes the first submission immediately, then drops duplicates within a window. If another submission arrives before the window expires, it's silently dropped.
426+
Cooldown executes the first submission immediately, then drops duplicates within a window. If another submission arrives before the window expires, it's quietly dropped with an INFO-level log.
427427

428428
### Per-Task Cooldown
429429

@@ -440,7 +440,7 @@ async def process_webhooks(
440440
# First call starts immediately and sets a 30-second window
441441
await docket.add(process_webhooks)()
442442

443-
# This one arrives 5 seconds later — silently dropped
443+
# This one arrives 5 seconds later — quietly dropped
444444
await docket.add(process_webhooks)()
445445
```
446446

src/docket/dependencies/_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ class AdmissionBlocked(Exception):
5757
concurrency limits, rate limits, or health gates.
5858
5959
When ``reschedule`` is True (default), the worker re-queues the task
60-
with a short delay. When False, the task is silently acknowledged
61-
and dropped (appropriate for debounce/cooldown where re-trying would
62-
just hit the same window).
60+
with a short delay. When False, the task is quietly acknowledged
61+
and dropped with an INFO-level log (appropriate for debounce/cooldown
62+
where re-trying would just hit the same window).
6363
6464
``retry_delay`` overrides the default reschedule delay when set.
6565
"""

src/docket/dependencies/_cooldown.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class Cooldown(Dependency["Cooldown"]):
1717
"""Execute first, drop duplicates within window.
1818
1919
Sets a Redis key on entry with a TTL equal to the window. If the key
20-
already exists, the task is blocked and silently dropped.
20+
already exists, the task is blocked and quietly dropped.
2121
2222
Works both as a default parameter and as ``Annotated`` metadata::
2323

0 commit comments

Comments
 (0)