Skip to content

Commit afb074d

Browse files
chrisguidryclaude
andauthored
Revert fakeredis to dev dependencies for PyPI compatibility (#180)
The previous change moved fakeredis to main dependencies, but PyPI doesn't allow git dependencies in published packages. We need to wait for an official release (version > 2.32.0, presumably 2.33.0) before we can use it as a main dependency. ## Changes - Moved fakeredis back to dev dependencies - Still using the main repo (not Nate's fork) at the commit with the fix - Updated comment to explain we're waiting for a PyPI release - Once released, we can use `fakeredis[lua]>=2.33.0` as a main dependency ## Why This Matters PyPI requires all dependencies to be proper versioned packages, not git references. While the fix we need is merged into the main repo, it hasn't been released to PyPI yet. Until then, we'll keep fakeredis as a dev dependency for testing purposes only. Related: cunla/fakeredis-py#427 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent 147daeb commit afb074d

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

pyproject.toml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ classifiers = [
2525
dependencies = [
2626
"cloudpickle>=3.1.1",
2727
"exceptiongroup>=1.2.0; python_version < '3.11'",
28-
# Using specific commit until version > 2.32.0 is released
29-
# This includes the fix for xpending_range to return all 4 required fields
30-
# See: https://github.com/cunla/fakeredis-py/pull/427
31-
"fakeredis[lua] @ git+https://github.com/cunla/fakeredis-py.git@ad50a0de8d6dce554fb629ec284bc4ccbc6a7f12",
3228
"opentelemetry-api>=1.30.0",
3329
"opentelemetry-exporter-prometheus>=0.51b0",
3430
"prometheus-client>=0.21.1",
@@ -44,6 +40,11 @@ dependencies = [
4440
dev = [
4541
"codespell>=2.4.1",
4642
"docker>=7.1.0",
43+
# Using specific commit until version > 2.32.0 is released to PyPI
44+
# This includes the fix for xpending_range to return all 4 required fields
45+
# Once released, we can use "fakeredis[lua]>=2.33.0" and move to main dependencies
46+
# See: https://github.com/cunla/fakeredis-py/pull/427
47+
"fakeredis[lua] @ git+https://github.com/cunla/fakeredis-py.git@ad50a0de8d6dce554fb629ec284bc4ccbc6a7f12",
4748
"ipython>=8.0.0",
4849
"mypy>=1.14.1",
4950
"opentelemetry-distro>=0.51b0",

uv.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)