There are several tests in Noda Time which expect that certain operations will overflow, given the right parameters.
This may or may not happen in Pyoda Time as it stands, because Python's integer is dynamic (unlike, for example, int or long in C#).
I have taken to marking such tests with the following decorator: @pytest.mark.xfail(reason="Python's dynamic integer size prevents Overflow")
However, there may also be instances where (in porting from Noda Time) we manually raise OverflowError. These may or may not be arbitrary in Python. In other cases they may be entirely justified.
Either way, I'll need to review this topic once the initial first stab at this port is in place.
There are several tests in Noda Time which expect that certain operations will overflow, given the right parameters.
This may or may not happen in Pyoda Time as it stands, because Python's integer is dynamic (unlike, for example, int or long in C#).
I have taken to marking such tests with the following decorator:
@pytest.mark.xfail(reason="Python's dynamic integer size prevents Overflow")However, there may also be instances where (in porting from Noda Time) we manually raise
OverflowError. These may or may not be arbitrary in Python. In other cases they may be entirely justified.Either way, I'll need to review this topic once the initial first stab at this port is in place.