Skip to content

Better audio solutions #36

Description

@christopher-buss

The sound-controller works, but I'd prefer to shy-away from using Dependency macro's to access flamework controllers in React component. React shouldn't need to know about Flamework at all to work, but the current approach doesn't easily allow this. Requiring flamework singleton's in React is a very quick and sure fire way to break storybooks.

That being said, audio also doesn't necessarily need to play during storybooks (although it'd be nice), so just early returning while IS_EDIT is true is not the most unreasonable approach, but I still believe it would be a better approach to avoid Flamework altogether.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions