Skip to content

Commit 1305109

Browse files
author
Sicheng Pan
committed
Clone log position and metrics
1 parent fb80560 commit 1305109

File tree

2 files changed

+38
-27
lines changed

2 files changed

+38
-27
lines changed

Diff for: go/pkg/sysdb/coordinator/model/collection.go

+13-9
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,19 @@ type CollectionToGc struct {
3232
}
3333

3434
type CreateCollection struct {
35-
ID types.UniqueID
36-
Name string
37-
ConfigurationJsonStr string
38-
Dimension *int32
39-
Metadata *CollectionMetadata[CollectionMetadataValueType]
40-
GetOrCreate bool
41-
TenantID string
42-
DatabaseName string
43-
Ts types.Timestamp
35+
ID types.UniqueID
36+
Name string
37+
ConfigurationJsonStr string
38+
Dimension *int32
39+
Metadata *CollectionMetadata[CollectionMetadataValueType]
40+
GetOrCreate bool
41+
TenantID string
42+
DatabaseName string
43+
Ts types.Timestamp
44+
LogPosition int64
45+
TotalRecordsPostCompaction uint64
46+
SizeBytesPostCompaction uint64 // Note: This represents the size of the records off the log
47+
LastCompactionTimeSecs uint64
4448
}
4549

4650
type DeleteCollection struct {

Diff for: go/pkg/sysdb/coordinator/table_catalog.go

+25-18
Original file line numberDiff line numberDiff line change
@@ -291,15 +291,18 @@ func (tc *Catalog) createCollectionImpl(txCtx context.Context, createCollection
291291
}
292292

293293
dbCollection := &dbmodel.Collection{
294-
ID: createCollection.ID.String(),
295-
Name: &createCollection.Name,
296-
ConfigurationJsonStr: &createCollection.ConfigurationJsonStr,
297-
Dimension: createCollection.Dimension,
298-
DatabaseID: databases[0].ID,
299-
Ts: ts,
300-
LogPosition: 0,
301-
VersionFileName: versionFileName,
302-
Tenant: createCollection.TenantID,
294+
ID: createCollection.ID.String(),
295+
Name: &createCollection.Name,
296+
ConfigurationJsonStr: &createCollection.ConfigurationJsonStr,
297+
Dimension: createCollection.Dimension,
298+
DatabaseID: databases[0].ID,
299+
VersionFileName: versionFileName,
300+
Tenant: createCollection.TenantID,
301+
Ts: ts,
302+
LogPosition: createCollection.LogPosition,
303+
TotalRecordsPostCompaction: createCollection.TotalRecordsPostCompaction,
304+
SizeBytesPostCompaction: createCollection.SizeBytesPostCompaction,
305+
LastCompactionTimeSecs: createCollection.LastCompactionTimeSecs,
303306
}
304307

305308
err = tc.metaDomain.CollectionDb(txCtx).Insert(dbCollection)
@@ -864,15 +867,19 @@ func (tc *Catalog) ForkCollection(ctx context.Context, forkCollection *model.For
864867
}
865868

866869
createCollection := &model.CreateCollection{
867-
ID: forkCollection.TargetCollectionID,
868-
Name: forkCollection.TargetCollectionName,
869-
ConfigurationJsonStr: sourceCollection.ConfigurationJsonStr,
870-
Dimension: sourceCollection.Dimension,
871-
Metadata: sourceCollection.Metadata,
872-
GetOrCreate: false,
873-
TenantID: sourceCollection.TenantID,
874-
DatabaseName: sourceCollection.DatabaseName,
875-
Ts: ts.Unix(),
870+
ID: forkCollection.TargetCollectionID,
871+
Name: forkCollection.TargetCollectionName,
872+
ConfigurationJsonStr: sourceCollection.ConfigurationJsonStr,
873+
Dimension: sourceCollection.Dimension,
874+
Metadata: sourceCollection.Metadata,
875+
GetOrCreate: false,
876+
TenantID: sourceCollection.TenantID,
877+
DatabaseName: sourceCollection.DatabaseName,
878+
Ts: ts.Unix(),
879+
LogPosition: sourceCollection.LogPosition,
880+
TotalRecordsPostCompaction: sourceCollection.TotalRecordsPostCompaction,
881+
SizeBytesPostCompaction: sourceCollection.SizeBytesPostCompaction,
882+
LastCompactionTimeSecs: sourceCollection.LastCompactionTimeSecs,
876883
}
877884

878885
createSegments := []*model.CreateSegment{}

0 commit comments

Comments
 (0)