Skip to content

Commit 87561f7

Browse files
authored
[BLD] Do not trigger deploy on merge to release branches (#4561)
## Description of changes This removes the `release/**` trigger from the `trigger-deploy` workflow so that deploys aren't created when hotfixes are merged to release branches. We want this to be a manual step for the time being to prevent unintentional deploys of the control plane when we are hotfixing the data plane. - Improvements & Bug fixes - Prevents hotfix merges from triggering a deploy of code that is potentially behind what is deployed. - New functionality - N/A - removes automation ## Test plan Manual testing -- we will have to manually deploy changes after merging hotfixes to release branches.
1 parent 464c2e5 commit 87561f7

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/release-chromadb.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ jobs:
220220
// - This workflow finishes for A and deploys A to Chroma Cloud
221221
// Chroma Cloud is now running A, but the last commit was B.
222222
"environment": "staging",
223-
"planes": "data,control"
223+
"planes": "control,data"
224224
}
225225
})
226226

.github/workflows/trigger-deploy.yaml

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ on:
55
push:
66
branches:
77
# main is not included here because it is handled by the release-chromadb.yaml workflow
8+
# production deploys (release branches) are also not here because they are currently
9+
# meant to be handled manually.
810
- rc/**-**-**
9-
- release/**-**-**
1011

1112
jobs:
1213
deploy:
@@ -25,7 +26,7 @@ jobs:
2526
ref: 'main',
2627
inputs: {
2728
'planes': 'control,data',
28-
environment: '${{ contains(github.ref, 'release/') && 'production' || 'staging' }}',
29+
environment: 'staging',
2930
'ignore-lock': true,
3031
'oss-ref': '${{ github.ref_name }}',
3132
'hosted-ref': '${{ github.ref_name }}'

0 commit comments

Comments
 (0)