Increase default sync timeout to 5 seconds

Author: GrahamCampbell

README.md

@@ -151,7 +151,7 @@ Here are the options available for the browser factory:
 | ignoreCertificateErrors | false    | Set chrome to ignore ssl errors                                                                  |
 | keepAlive          | true          | true to keep alive the chrome instance when the script terminates                                |
 | noSandbox          | false         | Useful to run in a docker container                                                              |
-| sendSyncDefaultTimeout | 3000      | Default timeout (ms) for sending sync messages                                                   |
+| sendSyncDefaultTimeout | 5000      | Default timeout (ms) for sending sync messages                                                   |
 | startupTimeout     | 30            | Maximum time in seconds to wait for chrome to start                                              |
 | userAgent          | none          | User agent to use for the whole browser  (see page api for alternative)                          |
 | userDataDir        | none          | chrome user data dir (default: a new empty dir is generated temporarily)                         |

src/Browser/BrowserProcess.php

@@ -140,7 +140,7 @@ public function start($binary, $options)
         $this->logger->debug('process: connecting using ' . $this->wsUri);
 
         // connect to browser
-        $connection = new Connection($this->wsUri, $this->logger, $options['sendSyncDefaultTimeout'] ?? 3000);
+        $connection = new Connection($this->wsUri, $this->logger, $options['sendSyncDefaultTimeout'] ?? 5000);
         $connection->connect();
 
         // connection delay

src/BrowserFactory.php

@@ -41,7 +41,7 @@ public function __construct(string $chromeBinary = null)
      * - ignoreCertificateErrors: set chrome to ignore ssl errors
      * - keepAlive: true to keep alive the chrome instance when the script terminates (default: false)
      * - noSandbox: enable no sandbox mode (default: false)
-     * - sendSyncDefaultTimeout: maximum time in ms to wait for synchronous messages to send (default 3000 ms)
+     * - sendSyncDefaultTimeout: maximum time in ms to wait for synchronous messages to send (default 5000 ms)
      * - startupTimeout: maximum time in seconds to wait for chrome to start (default: 30 sec)
      * - userAgent: user agent to use for the browser
      * - userDataDir: chrome user data dir (default: a new empty dir is generated temporarily)
@@ -118,7 +118,7 @@ public function getChromeVersion()
      * @param array $options options when creating the connection to the browser:
      *  - connectionDelay: amount of time in seconds to slows down connection for debugging purposes (default: none)
      *  - debugLogger: resource string ("php://stdout"), resource or psr-3 logger instance (default: none)
-     *  - sendSyncDefaultTimeout: maximum time in ms to wait for synchronous messages to send (default 3000 ms)
+     *  - sendSyncDefaultTimeout: maximum time in ms to wait for synchronous messages to send (default 5000 ms)
      *
      * @return Browser
      * @throws BrowserConnectionFailed
@@ -132,7 +132,7 @@ public static function connectToBrowser(string $uri, array $options = []): Brows
         }
 
         // connect to browser
-        $connection = new Connection($uri, $logger, $options['sendSyncDefaultTimeout'] ?? 3000);
+        $connection = new Connection($uri, $logger, $options['sendSyncDefaultTimeout'] ?? 5000);
 
         // try to connect
         try {

src/Communication/Connection.php

@@ -91,7 +91,7 @@ public function __construct($socketClient, LoggerInterface $logger = null, int $
         $this->setLogger($logger ?? new NullLogger());
 
         // set timeout
-        $this->sendSyncDefaultTimeout = $sendSyncDefaultTimeout ?? 3000;
+        $this->sendSyncDefaultTimeout = $sendSyncDefaultTimeout ?? 5000;
 
         // create socket client
         if (is_string($socketClient)) {