Merge branch '1.4' into 1.5

Author: GrahamCampbell

.github/workflows/static.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: '7.3'
+          php-version: '7.4'
           tools: composer:v2
           coverage: none
 

.styleci.yml

@@ -1,5 +1,7 @@
 preset: symfony
 
+version: 7.4
+
 risky: true
 
 enabled:

CHANGELOG.md

@@ -1,6 +1,15 @@
 # CHANGELOG
 
 
+## 1.4.1 (2022-03-25)
+
+* Added fallback to css layout metrics
+* Added missing destroyed setting
+* Prevent `Node::querySelector` from returning nodeId `0`
+* Fixed "What's new" page opening on startup
+* More fixes to enable eventual PHP 8.1 support
+
+
 ## 1.4.0 (2022-01-23)
 
 * Added support for `--no-proxy-server` and `--proxy-bypass-list`

README.md

@@ -473,7 +473,7 @@ header('Pragma: public');
 echo base64_decode($pdf->getBase64());
 ```
 
-Options `headerTempalte` and `footerTempalte`:
+Options `headerTemplate` and `footerTemplate`:
 
 Should be valid HTML markup with the following classes used to inject printing values into them:
 - date: formatted print date
@@ -745,7 +745,7 @@ $elem->sendKeys('Sample text');
 You can upload file to file from the input:
 
 ```php
-$elem->uploadFile('/path/to/file');
+$elem->sendFile('/path/to/file');
 ```
 
 You can get element text or attribute:

composer.json

@@ -41,6 +41,9 @@
         }
     },
     "config": {
+        "allow-plugins": {
+            "bamarni/composer-bin-plugin": true
+        },
         "preferred-install": "dist"
     }
 }

src/Browser/BrowserProcess.php

@@ -303,6 +303,7 @@ private function getArgsFromOptions($binary, array $options)
             '--disable-prompt-on-repost',
             '--disable-sync',
             '--disable-translate',
+            '--disable-features=ChromeWhatsNewUI',
             '--metrics-recording-only',
             '--no-first-run',
             '--safebrowsing-disable-auto-update',

src/Communication/Response.php

@@ -119,7 +119,6 @@ public function offsetGet($offset)
     /**
      * {@inheritdoc}
      */
-    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value): void
     {
         throw new \Exception('Responses are immutable');
@@ -128,7 +127,6 @@ public function offsetSet($offset, $value): void
     /**
      * {@inheritdoc}
      */
-    #[\ReturnTypeWillChange]
     public function offsetUnset($offset): void
     {
         throw new \Exception('Responses are immutable');

src/Communication/Session.php

@@ -135,6 +135,7 @@ public function destroy(): void
         }
         $this->emit('destroyed');
         $this->connection = null;
+        $this->destroyed = true;
         $this->removeAllListeners();
     }
 }

src/Cookies/Cookie.php

@@ -57,6 +57,7 @@ public function getDomain()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return \array_key_exists($offset, $this->data);
@@ -65,6 +66,7 @@ public function offsetExists($offset)
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         return $this->data[$offset] ?? null;

src/Cookies/CookiesCollection.php

@@ -44,6 +44,7 @@ public function addCookie(Cookie $cookie): void
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->cookies);
@@ -52,6 +53,7 @@ public function getIterator()
     /**
      * {@inheritdoc}
      */
+    #[\ReturnTypeWillChange]
     public function count()
     {
         return \count($this->cookies);