Toggling "Allow Incognito" on settings page turns the flag orange

[ericlaw1979]

Toggling "Allow Incognito" on the settings page turns the flag orange and enables it such that you end up with this funny UI whereby it offers to submit a report about a chrome: URL:

[ericlaw1979]

This also happens when toggling the "Allow access to file urls"

The problem goes away if you use Chrome's DevTools to inspect the background page. So the problem may be correlated with the Background page being marked "Inactive"?

[ericlaw1979]

It may not be relevant for this issue, but it seems like this:

chrome.tabs.query({}, (tabs) => {
      tabs.forEach((tab) => {
        setBrowserActionAndIcon(tab);
      });
    });

could be safely changed to

chrome.tabs.query({"active":true}, (tabs) => {
      tabs.forEach((tab) => {
        setBrowserActionAndIcon(tab);
      });
    });

This would speed up the initial load cost?

[ericlaw1979]

One other oddity; if I inspect the background page while toggling these checkboxes, the |Sources| tab seems to show the background page's script loading multiple times. I don't see this with one of my own extensions that uses a background page/js.

[ericlaw1979]

Documentation for chrome.tabs.onActivated notes that it can fire before tab.url is available, so the setBrowserActionAndIcon call should probably check whether tab.url is assigned before attempting to call startsWith on it.

[ericlaw1979]

This also reproduces on Mac OSX in Chrome Canary with the official extension.

Interestingly, when I build the extension locally and load it "unpacked", the problem does not reproduce.