fix(spectre): remove duplicate metrics service causing double scrape (#275)

* fix(spectre): remove duplicate metrics service causing double scrape

The chart created two Services (spectre and spectre-metrics) both
exposing port 9090 with the same selector labels. The ServiceMonitor
matched both, producing two identical scrape jobs (spectre and
spectre-metrics) with ~38.7K duplicate series.

- Remove service-metrics.yaml (duplicate metrics-only service)
- Add metrics port (9090) to default service.ports in values.yaml
- Add metricRelabelings support to ServiceMonitor template
- Bump chart version 0.3.4 → 0.3.5

* fix(spectre): skip metrics port in test-connection

Metrics port 9090 is not available in CI kind cluster since spectre
requires valid config/keys to start its metrics server. Only test
the listen port for connectivity.

Author: devkoriel

charts/spectre/Chart.yaml

@@ -22,7 +22,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.3.4
+version: 0.3.5
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

charts/spectre/templates/service-metrics.yaml

@@ -33,6 +33,10 @@ spec:
     relabelings:
     {{- toYaml .Values.serviceMonitor.relabelings | nindent 4 }}
     {{- end }}
+    {{- if .Values.serviceMonitor.metricRelabelings }}
+    metricRelabelings:
+    {{- toYaml .Values.serviceMonitor.metricRelabelings | nindent 4 }}
+    {{- end }}
   jobLabel: "{{ .Release.Name }}"
   selector:
     matchLabels:

charts/spectre/templates/servicemonitor.yaml

@@ -10,6 +10,7 @@ spec:
   containers:
   {{- $serviceName := include "spectre.fullname" . }}
   {{- range $name, $config := .Values.service.ports }}
+  {{- if ne $name "metrics" }}
     - name: nc-{{ $name }}
       image: busybox
       command: ['nc']
@@ -19,4 +20,5 @@ spec:
         - '{{ $serviceName }}'
         - '{{ $config.port }}'
   {{- end }}
+  {{- end }}
   restartPolicy: Never

charts/spectre/templates/tests/test-connection.yaml

@@ -102,6 +102,9 @@ securityContext: {}
 service:
   type: ClusterIP
   ports:
+    metrics:
+      port: 9090
+      protocol: TCP
     listen:
       port: 8080
       protocol: TCP
@@ -184,6 +187,8 @@ serviceMonitor:
   scrapeTimeout: 60s
   # -- ServiceMonitor relabelings
   relabelings: []
+  # -- ServiceMonitor metricRelabelings
+  metricRelabelings: []
 
 # -- Extra K8s manifests to deploy
 extraObjects: []