Modify isSamePerson test and valid phone test

Author: chrystalquek

src/main/java/seedu/address/logic/parser/person/ParserUtil.java

@@ -65,16 +65,6 @@ public static Phone parsePhone(Optional<String> phone) throws ParseException {
         return new Phone(trimmedPhone);
     }
 
-    /**
-     * Parses a {@code String phone} into a {@code Phone}.
-     * Leading and trailing whitespaces will be trimmed.
-     *
-     * @throws ParseException if the given {@code phone} is invalid.
-     */
-    public static Phone parsePhone(String phone) throws ParseException {
-        return parsePhone(Optional.of(phone));
-    }
-
     /**
      * Parses a {@code String email} into an {@code Email}.
      * Leading and trailing whitespaces will be trimmed.

src/test/java/seedu/address/logic/parser/person/ParserUtilTest.java

@@ -5,6 +5,8 @@
 import static seedu.address.testutil.Assert.assertThrows;
 import static seedu.address.testutil.TypicalIndexes.INDEX_FIRST_PERSON;
 
+import java.util.Optional;
+
 import org.junit.jupiter.api.Test;
 
 import seedu.address.logic.parser.exceptions.ParseException;
@@ -15,12 +17,12 @@
 
 public class ParserUtilTest {
     private static final String INVALID_NAME = "R@chel";
-    private static final String INVALID_PHONE = "+651234";
+    private static final Optional<String> INVALID_PHONE = Optional.of("+651234");
     private static final String INVALID_EMAIL = "example.com";
     private static final String INVALID_ROLE = "friend";
 
     private static final String VALID_NAME = "Rachel Walker";
-    private static final String VALID_PHONE = "123456";
+    private static final Optional<String> VALID_PHONE = Optional.of("123456");
     private static final String VALID_EMAIL = "rachel@example.com";
     private static final String VALID_ROLE = "stk";
 
@@ -48,7 +50,7 @@ public void parseIndex_validInput_success() throws Exception {
 
     @Test
     public void parseName_null_throwsNullPointerException() {
-        assertThrows(NullPointerException.class, () -> ParserUtil.parseName((String) null));
+        assertThrows(NullPointerException.class, () -> ParserUtil.parseName(null));
     }
 
     @Test
@@ -82,14 +84,14 @@ public void parsePhone_validValueWithoutWhitespace_returnsPhone() throws Excepti
 
     @Test
     public void parsePhone_validValueWithWhitespace_returnsTrimmedPhone() throws Exception {
-        String phoneWithWhitespace = WHITESPACE + VALID_PHONE + WHITESPACE;
+        Optional<String> phoneWithWhitespace = Optional.of(WHITESPACE + VALID_PHONE.get() + WHITESPACE);
         Phone expectedPhone = new Phone(VALID_PHONE);
         assertEquals(expectedPhone, ParserUtil.parsePhone(phoneWithWhitespace));
     }
 
     @Test
     public void parseEmail_null_throwsNullPointerException() {
-        assertThrows(NullPointerException.class, () -> ParserUtil.parseEmail((String) null));
+        assertThrows(NullPointerException.class, () -> ParserUtil.parseEmail(null));
     }
 
     @Test

src/test/java/seedu/address/model/person/person/PersonTest.java

@@ -44,7 +44,7 @@ public void isSamePerson() {
 
         // same name, same phone, same email, different attributes -> returns true
         editedAlice = new PersonBuilder(ALICE)
-                .withDescription("wnjevjnkklfwe").build();
+                .withDescription(VALID_DESCRIPTION_BOB).build();
         assertTrue(ALICE.isSamePerson(editedAlice));
     }