Sort statistics (WIP)

Author: chrzaszcz

src/tr.erl

@@ -29,7 +29,7 @@
          reduce_call_trees/1,
          top_call_trees/0, top_call_trees/1, top_call_trees/2,
          print_sorted_call_stat/2,
-         sorted_call_stat/1,
+         sorted_call_stat/1, sorted_call_stat/2,
          call_stat/1, call_stat/2]).
 
 %% API - utilities
@@ -181,6 +181,13 @@
 -type tb_acc_list() :: [[tr()]].
 -type tb_acc() :: tb_acc_tree() | tb_acc_list().
 
+-type sorted_call_stat_options() :: #{sort_by => call_stat_field()}.
+%% Options for sorted call statistics.
+%%
+%% `sort_by' is the field name to sort by (default: `acc_time').
+
+-type call_stat_field() :: count | acc_time | own_time.
+
 -type call() :: {call, {module(), atom(), list()}}.
 -type result() :: {return | exception, any()}. % Result of a function call.
 -type simple_tr() :: call() | result().
@@ -482,7 +489,14 @@ print_sorted_call_stat(KeyF, Limit) ->
 %% @see call_stat/1
 -spec sorted_call_stat(selector(Key)) -> [{Key, call_count(), acc_time(), own_time()}].
 sorted_call_stat(KeyF) ->
-    lists:reverse(sort_by_time(call_stat(KeyF))).
+    sorted_call_stat(KeyF, #{}).
+
+%% @doc TODO
+-spec sorted_call_stat(selector(Key), sorted_call_stat_options()) ->
+    [{Key, call_count(), acc_time(), own_time()}].
+sorted_call_stat(KeyF, Options) ->
+    SortBy = maps:get(sort_by, Options, acc_time),
+    lists:reverse(sort_call_stat(SortBy, call_stat(KeyF))).
 
 %% @doc Returns call time statistics for traces selected from `tab()'.
 %%
@@ -1018,8 +1032,15 @@ filter_range(_PrefF, #tr{event = Event}, _State, _MaxDepth) when ?is_msg(Event)
 
 %% Call stat
 
-sort_by_time(MapStat) ->
-    lists:keysort(3, [{Key, Count, AccTime, OwnTime} || {Key, {Count, AccTime, OwnTime}} <- maps:to_list(MapStat)]).
+-spec sort_call_stat(call_stat_field(), #{Key => {call_count(), acc_time(), own_time()}}) ->
+    [{Key, call_count(), acc_time(), own_time()}].
+sort_call_stat(SortBy, MapStat) ->
+    Rows = [{Key, Count, AccTime, OwnTime} || {Key, {Count, AccTime, OwnTime}} <- maps:to_list(MapStat)],
+    lists:keysort(sort_by_pos(SortBy), Rows).
+
+sort_by_pos(count) -> 2;
+sort_by_pos(acc_time) -> 3;
+sort_by_pos(own_time) -> 4.
 
 call_stat_step(_KeyF, #tr{event = Event}, State) when ?is_msg(Event) ->
     State;