Skip to content

Commit bd09a71

Browse files
committed
refactor(dialogue): update dialogue option handling and add tests
1 parent ec8011c commit bd09a71

2 files changed

Lines changed: 24 additions & 4 deletions

File tree

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package net.runelite.client.plugins.microbot.util.dialogues;
2+
3+
import org.junit.Test;
4+
5+
import static org.junit.Assert.assertFalse;
6+
import static org.junit.Assert.assertTrue;
7+
8+
public class Rs2DialogueTest {
9+
@Test
10+
public void isContinuePromptTextAcceptsContinuePrompt() {
11+
assertTrue(Rs2Dialogue.isContinuePromptText("<col=ffffff>Click here to continue</col>"));
12+
}
13+
14+
@Test
15+
public void isContinuePromptTextRejectsChatboxInputs() {
16+
assertFalse(Rs2Dialogue.isContinuePromptText("Enter amount:"));
17+
assertFalse(Rs2Dialogue.isContinuePromptText("Search"));
18+
assertFalse(Rs2Dialogue.isContinuePromptText("abyssal whip"));
19+
}
20+
}

runelite-client/src/test/resources/threadsafety/client-thread-guardrail-baseline.txt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,11 +163,11 @@ net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#handleQuestOptio
163163
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#hasDialogueOptionTitle(String, boolean): boolean -> net.runelite.api.widgets.Widget#getDynamicChildren(): Widget[]
164164
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#hasDialogueOptionTitle(String, boolean): boolean -> net.runelite.api.widgets.Widget#getText(): String
165165
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#hasSelectAnOption(): boolean -> net.runelite.api.widgets.Widget#getDynamicChildren(): Widget[]
166-
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$clickOption$2(Widget, String): boolean -> net.runelite.api.widgets.Widget#getText(): String
167166
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$clickOption$3(Widget, String): boolean -> net.runelite.api.widgets.Widget#getText(): String
168-
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$getCombinationOption$8(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getName(): String
169-
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$getDialogueOption$0(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getText(): String
170-
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$hasDialogueOption$1(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getText(): String
167+
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$clickOption$4(Widget, String): boolean -> net.runelite.api.widgets.Widget#getText(): String
168+
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$getCombinationOption$9(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getName(): String
169+
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$getDialogueOption$1(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getText(): String
170+
net.runelite.client.plugins.microbot.util.dialogues.Rs2Dialogue#lambda$hasDialogueOption$2(boolean, String, Widget): boolean -> net.runelite.api.widgets.Widget#getText(): String
171171
net.runelite.client.plugins.microbot.util.equipment.Rs2Equipment#<clinit>(): void -> net.runelite.api.EquipmentInventorySlot#getSlotIdx(): int
172172
net.runelite.client.plugins.microbot.util.equipment.Rs2Equipment#<clinit>(): void -> net.runelite.api.EquipmentInventorySlot#values(): EquipmentInventorySlot[]
173173
net.runelite.client.plugins.microbot.util.equipment.Rs2Equipment#equipment(): ItemContainer -> net.runelite.api.Client#getItemContainer(int): ItemContainer

0 commit comments

Comments
 (0)