Skip to content

Commit 1290d52

Browse files
authored
cp: ci: Remove environments (3462) into core_r0.16.0 (NVIDIA#3481)
Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
1 parent 5a1bf63 commit 1290d52

16 files changed

+31
-79
lines changed

.github/workflows/_build_test_publish_wheel.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ on:
1717
type: boolean
1818
default: true
1919
secrets:
20-
TWINE_USERNAME:
21-
required: true
2220
TWINE_PASSWORD:
2321
required: true
2422

@@ -147,7 +145,6 @@ jobs:
147145
needs: [build-and-test-wheels]
148146
runs-on: ubuntu-latest
149147
if: inputs.no-publish == false
150-
environment: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/r')) && 'main' || 'public' }}
151148
strategy:
152149
fail-fast: false
153150
matrix:
@@ -170,7 +167,7 @@ jobs:
170167

171168
- name: Publish wheels
172169
env:
173-
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
170+
TWINE_USERNAME: __token__
174171
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
175172
TWINE_REPOSITORY: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/r')) && 'pypi' || 'testpypi' }}
176173
PLATFORM: ${{ matrix.PLATFORM }}

.github/workflows/_release_library.yml

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
name: 'Release'
15+
name: "Release"
1616

1717
defaults:
1818
run:
@@ -39,12 +39,8 @@ on:
3939
type: boolean
4040
default: true
4141
secrets:
42-
TWINE_USERNAME:
43-
required: true
4442
TWINE_PASSWORD:
4543
required: true
46-
SLACK_WEBHOOK_ADMIN:
47-
required: true
4844
SLACK_WEBHOOK:
4945
required: true
5046
PAT:
@@ -62,12 +58,10 @@ jobs:
6258
ref: ${{ inputs.release-ref }}
6359
no-publish: true
6460
secrets:
65-
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
6661
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
6762

6863
bump-next-version:
6964
runs-on: ubuntu-latest
70-
environment: main # ${{ inputs.dry-run == true && 'public' || 'main' }}
7165
needs: build-test-publish-wheels-dry-run
7266
if: |
7367
(
@@ -90,8 +84,8 @@ jobs:
9084
- name: Bump version MCore
9185
id: bump-version-mcore
9286
env:
93-
SRC_DIR: ''
94-
PYPROJECT_NAME: 'megatron.core'
87+
SRC_DIR: ""
88+
PYPROJECT_NAME: "megatron.core"
9589
run: |
9690
set +u
9791
cd ${{ github.run_id }}
@@ -129,8 +123,8 @@ jobs:
129123
- name: Bump version MFSDP
130124
id: bump-version-mfsdp
131125
env:
132-
SRC_DIR: 'megatron/core/distributed/fsdp/src/'
133-
PYPROJECT_NAME: 'megatron_fsdp'
126+
SRC_DIR: "megatron/core/distributed/fsdp/src/"
127+
PYPROJECT_NAME: "megatron_fsdp"
134128
run: |
135129
set +u
136130
@@ -323,7 +317,6 @@ jobs:
323317
create-gh-release:
324318
needs: [build-test-publish-wheels, bump-next-version]
325319
runs-on: ubuntu-latest
326-
environment: ${{ inputs.dry-run == true && 'public' || 'main' }}
327320
if: |
328321
(
329322
success() || !failure()
@@ -405,7 +398,6 @@ jobs:
405398
notify:
406399
needs: [build-test-publish-wheels, create-gh-release]
407400
runs-on: ubuntu-latest
408-
environment: ${{ inputs.dry-run == true && 'public' || 'main' }}
409401
env:
410402
GH_URL: https://github.com/${{ github.repository }}/releases/tag/v${{ needs.build-test-publish-wheels.outputs.version }}
411403
PYPI_URL: https://${{ inputs.dry-run == true && 'test.' || '' }}pypi.org/project/${{ needs.build-test-publish-wheels.outputs.pypi-name }}/${{ needs.build-test-publish-wheels.outputs.version }}/

.github/workflows/_update_dependencies.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,6 @@ on:
99
secrets:
1010
PAT:
1111
required: true
12-
AZURE_CLIENT_ID:
13-
required: true
14-
AZURE_TENANT_ID:
15-
required: true
16-
AZURE_SUBSCRIPTION_ID:
17-
required: true
1812
SSH_KEY:
1913
required: true
2014
SSH_PWD:
@@ -32,26 +26,12 @@ jobs:
3226
run: echo "date=$(date +%F)" | tee -a "$GITHUB_OUTPUT"
3327

3428
update-lockfile:
35-
environment: nemo-ci
3629
runs-on: linux-amd64-cpu16
3730
needs: [pre-flight]
3831
env:
3932
SOURCE_BRANCH: ${{ needs.pre-flight.outputs.bump-branch }}
4033
TARGET_BRANCH: ${{ inputs.target-branch }}
4134
steps:
42-
- name: Install Azure CLI
43-
run: curl -sL https://aka.ms/InstallAzureCLIDeb | sudo bash
44-
45-
- name: Azure Login
46-
uses: azure/login@v2
47-
with:
48-
client-id: ${{ secrets.AZURE_CLIENT_ID }}
49-
tenant-id: ${{ secrets.AZURE_TENANT_ID }}
50-
subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
51-
52-
- name: Azure ACR Login
53-
run: az acr login --name nemoci
54-
5535
- name: Checkout repo
5636
uses: actions/checkout@v4
5737
with:
@@ -96,7 +76,6 @@ jobs:
9676
create-pr:
9777
needs: [update-lockfile, pre-flight]
9878
runs-on: ubuntu-latest
99-
environment: main
10079
env:
10180
SOURCE_BRANCH: ${{ needs.pre-flight.outputs.bump-branch }}
10281
TARGET_BRANCH: ${{ inputs.target-branch }}

.github/workflows/auto-assign-milestone.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ permissions:
1313
jobs:
1414
assign-milestone:
1515
runs-on: ubuntu-latest
16-
environment: nemo-ci
1716
if: github.repository == 'NVIDIA/Megatron-LM'
1817
steps:
1918
- name: Get PR info

.github/workflows/auto-reminder-bot.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ on:
99

1010
jobs:
1111
run-script:
12-
environment: main
1312
name: Run Auto Reminder Bot
1413
runs-on: ubuntu-latest
1514
if: github.repository == 'NVIDIA/Megatron-LM'
@@ -28,7 +27,7 @@ jobs:
2827
2928
- name: Run Auto Reminder Bot
3029
run: |
31-
export SLACK_TOKEN=${{ secrets.SLACK_TOKEN }}
32-
export SLACK_WEBHOOK_URL=${{ secrets.SLACK_WEBHOOK_URL }}
30+
export SLACK_TOKEN=${{ secrets.SLACK_BOT_TOKEN }}
31+
export SLACK_WEBHOOK_URL=${{ secrets.SLACK_REVIEW_REMINDER_CHANNEL_WEBHOOK }}
3332
export GH_TOKEN=${{ secrets.PAT }}
3433
python tests/test_utils/python_scripts/auto_reminder_github.py

.github/workflows/auto-update-copy-pr-bot.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,11 @@ name: Auto Update Copy PR Bot
33
on:
44
workflow_dispatch:
55
schedule:
6-
- cron: '0 0 * * *'
6+
- cron: "0 0 * * *"
77

88
jobs:
99
auto-update-copy-pr-bot:
1010
runs-on: ubuntu-latest
11-
environment: nemo-ci
1211
if: github.repository == 'NVIDIA/Megatron-LM'
1312
steps:
1413
- name: Checkout code

.github/workflows/build-test-publish-wheel.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ on:
1818
push:
1919
branches:
2020
- main
21-
- 'pull-request/[0-9]+'
22-
- 'deploy-release/*'
21+
- "pull-request/[0-9]+"
22+
- "deploy-release/*"
2323
merge_group:
2424
types: [checks_requested]
2525

@@ -42,8 +42,7 @@ jobs:
4242
with:
4343
no-publish: true
4444
secrets:
45-
TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
46-
TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
45+
TWINE_PASSWORD: ${{ (github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/heads/r')) && secrets.SVC_PYPI_TOKEN || secrets.SVC_PYPI_TEST_TOKEN }}
4746

4847
build-test-publish-wheel-summary:
4948
needs: [pre-flight, build-test-publish-wheels]
@@ -65,7 +64,7 @@ jobs:
6564
env:
6665
GH_TOKEN: ${{ github.token }}
6766
GITHUB_RUN_ID: ${{ github.run_id }}
68-
SKIPPING_IS_ALLOWED: ${{ needs.pre-flight.outputs.docs_only == 'true' || needs.pre-flight.outputs.is_deployment_workflow == 'true' || needs.pre-flight.outputs.is_merge_group == 'true' || needs.pre-flight.outputs.is_ci_workload == 'true' || github.ref != 'refs/heads/main' }}
67+
SKIPPING_IS_ALLOWED: true
6968
run: |
7069
FAILED_JOBS=$(gh run view $GITHUB_RUN_ID --json jobs --jq '[.jobs[] | select(.status == "completed" and .conclusion != "success")] | length') || echo 0
7170

.github/workflows/cherry-pick-release-commit.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ jobs:
2626
target-branches-pattern: 'core_(*dev_)?r[0-9]+\.[0-9]+\.[0-9]+'
2727
secrets:
2828
PAT: ${{ secrets.PAT }}
29-
SLACK_WEBHOOK_ADMIN: ${{ secrets.SLACK_WEBHOOK_ADMIN }}
30-
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
29+
SLACK_WEBHOOK_ADMIN: ${{ secrets.SLACK_TEAM_GROUP_ID }}
30+
SLACK_WEBHOOK: ${{ secrets.SLACK_CI_CHANNEL_WEBHOOK }}

.github/workflows/cicd-approve-test-queue.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@ jobs:
181181
steps:
182182
- name: Notify
183183
env:
184-
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
185-
SLACK_WEBHOOK_ADMIN: <!subteam^${{ secrets.SLACK_WEBHOOK_ADMIN }}>
184+
SLACK_WEBHOOK: ${{ secrets.SLACK_CI_CHANNEL_WEBHOOK }}
185+
SLACK_WEBHOOK_ADMIN: <!subteam^${{ secrets.SLACK_TEAM_GROUP_ID }}>
186186
GITHUB_RUN_ID: ${{ github.run_id }}
187187
GITHUB_REPOSITORY: ${{ github.repository }}
188188
run: |

.github/workflows/dependabot.yml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ permissions:
1111
jobs:
1212
get-release-branch-names:
1313
runs-on: ubuntu-latest
14-
environment: nemo-ci
1514
outputs:
1615
mcore: ${{ steps.get-branch.outputs.mcore_release_branch }}
1716
if: github.repository == 'NVIDIA/Megatron-LM'
@@ -41,9 +40,6 @@ jobs:
4140
target-branch: ${{ matrix.target-branch }}
4241
secrets:
4342
PAT: ${{ secrets.PAT }}
44-
AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
45-
AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
46-
AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
4743
SSH_KEY: ${{ secrets.SSH_KEY }}
4844
SSH_PWD: ${{ secrets.SSH_PWD }}
4945

@@ -54,8 +50,8 @@ jobs:
5450
steps:
5551
- name: Notify
5652
env:
57-
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
58-
SLACK_WEBHOOK_ADMIN: <!subteam^${{ secrets.SLACK_WEBHOOK_ADMIN }}>
53+
SLACK_WEBHOOK: ${{ secrets.SLACK_CI_CHANNEL_WEBHOOK }}
54+
SLACK_WEBHOOK_ADMIN: <!subteam^${{ secrets.SLACK_TEAM_GROUP_ID }}>
5955
GITHUB_RUN_ID: ${{ github.run_id }}
6056
GITHUB_REPOSITORY: ${{ github.repository }}
6157
run: |

0 commit comments

Comments
 (0)