Commit 0c1f627
Warn about unsupported blocks after chunk loading (#1880)
* feat: warn about unsupported blocks after chunk loading
Track block names that are not recognized by any BlockProvider in a
concurrent set within BlockPalette. After chunk loading completes, log a
warning listing the unsupported block names and suggesting the user
update Chunky or check the minecraft label on GitHub.
Fixes #1801
* refactor: move unsupported blocks check into loadChunks, use HashSet
Address review feedback from @NotStirred:
- Move unsupported blocks warning from Scene caller into loadChunks itself,
since the check should run for all callers, not just the scene reload path
- Change unsupportedBlocks from ConcurrentHashMap.newKeySet() to HashSet
since put() locks internally and all puts complete before getUnsupportedBlocks
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---------
Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent 1db9225 commit 0c1f627
2 files changed
Lines changed: 20 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
134 | 138 | | |
135 | 139 | | |
136 | 140 | | |
| |||
139 | 143 | | |
140 | 144 | | |
141 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
142 | 154 | | |
143 | 155 | | |
144 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1466 | 1466 | | |
1467 | 1467 | | |
1468 | 1468 | | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
1469 | 1477 | | |
1470 | 1478 | | |
1471 | 1479 | | |
| |||
0 commit comments