Skip to content

Commit 302d078

Browse files
authored
Merge pull request nus-cs2103-AY2021S1#69 from Nijnxw/branch-v1.2-viewlsn
Fix bug for view lesson command
2 parents fac4dba + 3bef6a6 commit 302d078

5 files changed

Lines changed: 14 additions & 6 deletions

File tree

src/main/java/seedu/address/logic/commands/ViewLsnCommand.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ private String getMessage(Model model) {
4646
@Override
4747
public CommandResult execute(Model model) {
4848
requireNonNull(model);
49+
model.updateFilteredGroupList(grpPredicate);
4950
model.updateFilteredLessonList(lsnPredicate);
5051
return new CommandResult(this.getMessage(model));
5152
}

src/main/java/seedu/address/logic/parser/ViewLsnCommandParser.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,5 @@ public ViewLsnCommand parse(String args) throws ParseException {
4343
private static boolean arePrefixesPresent(ArgumentMultimap argumentMultimap, Prefix... prefixes) {
4444
return Stream.of(prefixes).allMatch(prefix -> argumentMultimap.getValue(prefix).isPresent());
4545
}
46+
4647
}

src/main/java/seedu/address/model/ModelManager.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public ModelManager(ReadOnlyAddressBook addressBook, ReadOnlyUserPrefs userPrefs
5858
filteredGroups = new FilteredList<>(this.serenity.getGroupList());
5959
students = new ArrayObservableList<>(new UniqueStudentList().asUnmodifiableObservableList());
6060
lessons = new ArrayObservableList<>(new UniqueLessonList().asUnmodifiableObservableList());
61-
filteredLessons = new FilteredList<>(new UniqueLessonList().asUnmodifiableObservableList());
61+
filteredLessons = new FilteredList<>(lessons);
6262
studentsInfo = new ArrayObservableList<>(new UniqueStudentInfoList().asUnmodifiableObservableList());
6363
}
6464

@@ -79,7 +79,7 @@ public ModelManager(ReadOnlyAddressBook addressBook, ReadOnlyUserPrefs userPrefs
7979
filteredGroups = new FilteredList<>(this.serenity.getGroupList());
8080
students = new ArrayObservableList<>(new UniqueStudentList().asUnmodifiableObservableList());
8181
lessons = new ArrayObservableList<>(new UniqueLessonList().asUnmodifiableObservableList());
82-
filteredLessons = new FilteredList<>(new UniqueLessonList().asUnmodifiableObservableList());
82+
filteredLessons = new FilteredList<>(lessons);
8383
studentsInfo = new ArrayObservableList<>(new UniqueStudentInfoList().asUnmodifiableObservableList());
8484
}
8585

@@ -223,8 +223,8 @@ public void updateFilteredLessonList(Predicate<Lesson> predicate) {
223223

224224
@Override
225225
public void updateStudentInfoList() {
226-
if (!filteredGroups.isEmpty() || !lessons.isEmpty()) {
227-
this.studentsInfo.setAll(this.lessons.get(0).getStudentsInfoAsUnmodifiableObservableList());
226+
if (!filteredGroups.isEmpty() || !filteredLessons.isEmpty()) {
227+
this.studentsInfo.setAll(this.filteredLessons.get(0).getStudentsInfoAsUnmodifiableObservableList());
228228
}
229229
}
230230

@@ -245,7 +245,7 @@ public ObservableList<Lesson> getLessonList() {
245245

246246
@Override
247247
public ObservableList<Lesson> getFilteredLessonList() {
248-
return lessons;
248+
return filteredLessons;
249249
}
250250

251251
@Override

src/main/java/seedu/address/model/group/Group.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ public int hashCode() {
143143

144144
@Override
145145
public String toString() {
146-
return name + "," + students.toString();
146+
return String.format("Group %s", name);
147147
}
148+
148149
}

src/main/java/seedu/address/model/group/Lesson.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,5 +64,10 @@ public boolean equals(Object obj) {
6464
return otherClass.getName().equals(getName())
6565
&& otherClass.getStudentsInfo().equals(getStudentsInfo());
6666
}
67+
68+
@Override
69+
public String toString() {
70+
return String.format("Lesson %s", name);
71+
}
6772
}
6873

0 commit comments

Comments
 (0)