Skip to content

Commit 594b590

Browse files
Improves error handling in backup module.
Enhances error message display in the backup module by providing more specific feedback to the user. This includes improved handling of AJAX errors, ensuring that users receive informative messages when operations fail.
1 parent c961bfa commit 594b590

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

modules/Backup/Views/list.php

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ className: "btn btn-teal",
199199
Swal.fire({
200200
icon: 'success',
201201
title: '<?= lang('Backend.success') ?>',
202-
text: '<?= lang('Backend.created',['Backup']) ?>',
202+
text: '<?= lang('Backend.created', ['Backup']) ?>',
203203
confirmButtonText: '<?= lang('Backup.download') ?>',
204204
showCancelButton: true,
205205
cancelButtonText: '<?= lang('Backend.cancel') ?>'
@@ -216,53 +216,55 @@ className: "btn btn-teal",
216216
table.ajax.reload();
217217
});
218218
} else {
219-
Swal.fire('<?= lang('Backend.error') ?>', response.error || '<?= lang('Backend.notCreated',['Backup']) ?>', 'error');
219+
Swal.fire('<?= lang('Backend.error') ?>', response.error || '<?= lang('Backend.notCreated', ['Backup']) ?>', 'error');
220220
}
221221
},
222222
error: function(jqXHR, textStatus, errorThrown) {
223-
Swal.fire('<?= lang('Backend.error') ?>', jqXHR.responseJSON.error || '<?= lang('Backend.operationFailed') ?>', 'error');
223+
let msg = (jqXHR.responseJSON && jqXHR.responseJSON.error) ? jqXHR.responseJSON.error : '<?= lang('Backend.operationFailed') ?>';
224+
Swal.fire('<?= lang('Backend.error') ?>', msg, 'error');
224225
}
225226
});
226227
});
227228
$(function() {
228229
bsCustomFileInput.init();
229230
});
230231

231-
function remove (id) {
232+
function remove(id) {
232233
Swal.fire({
233234
icon: 'warning',
234-
title: '<?= lang('Backend.confirmDelete',['Backup']) ?>',
235+
title: '<?= lang('Backend.confirmDelete', ['Backup']) ?>',
235236
confirmButtonText: '<?= lang('Backend.delete') ?>',
236237
showCancelButton: true,
237238
cancelButtonText: '<?= lang('Backend.cancel') ?>',
238239
allowOutsideClick: false
239240
}).then((result) => {
240241
if (result.isConfirmed) {
241242
$.ajax({
242-
url: '/backend/backup/delete/'+ id,
243+
url: '/backend/backup/delete/' + id,
243244
type: 'POST',
244245
dataType: 'json',
245246
success: function(response) {
246247
if (response.success) {
247248
Swal.fire({
248249
icon: 'success',
249250
title: '<?= lang('Backend.success') ?>',
250-
text: response.message || '<?= lang('Backend.deleted',['Backup']) ?>',
251+
text: response.message || '<?= lang('Backend.deleted', ['Backup']) ?>',
251252
});
252253
table.ajax.reload();
253254
} else {
254255
Swal.fire({
255256
icon: 'error',
256257
title: '<?= lang('Backend.error') ?>',
257-
text: response.error || '<?= lang('Backend.notDeleted',['Backup']) ?>',
258+
text: response.error || '<?= lang('Backend.notDeleted', ['Backup']) ?>',
258259
});
259260
}
260261
},
261262
error: function(jqXHR, textStatus, errorThrown) {
263+
let msg = (jqXHR.responseJSON && jqXHR.responseJSON.error) ? jqXHR.responseJSON.error : '<?= lang('Backend.operationFailed') ?>';
262264
Swal.fire({
263265
icon: 'error',
264266
title: '<?= lang('Backend.error') ?>',
265-
text: jqXHR.responseJSON.error || '<?= lang('Backend.operationFailed') ?>',
267+
text: msg,
266268
});
267269
}
268270
});

0 commit comments

Comments
 (0)