cgtracker_test: skip if test cannot mkdir

kkourt · kkourt · commit 5e924fbe2d87 · 2024-11-29T17:20:19.000+01:00
In GH runners, we get:

--- FAIL: TestCgTrackerMap (0.12s)
    cgtracker_test.go:73: '/sys/fs/cgroup' is cgroup v1
    cgtracker_test.go:81: failed to create test dir: mkdir /sys/fs/cgroup/cgtracker-test-1715271346: read-only file system

So it seems that we cannot execute the test there. Skip it for now.

Signed-off-by: Kornilios Kourtis &lt;kornilios@isovalent.com&gt;
diff --git a/pkg/cgtracker/test/cgtracker_test.go b/pkg/cgtracker/test/cgtracker_test.go
@@ -78,7 +78,7 @@ func cgfsMkdirTemp(t *testing.T, cgfsPath string) string {
 	// create tempdir
 	dir, err := os.MkdirTemp(cgfsPath, "cgtracker-test-*")
 	if err != nil {
-		t.Fatalf("failed to create test dir: %s", err)
+		t.Skipf("skipping test, failed to create test dir: %s", err)
 	}
 	t.Cleanup(func() {
 		err := os.RemoveAll(dir)

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ func cgfsMkdirTemp(t *testing.T, cgfsPath string) string {`
`78`	`78`	`// create tempdir`
`79`	`79`	`dir, err := os.MkdirTemp(cgfsPath, "cgtracker-test-*")`
`80`	`80`	`if err != nil {`
`81`		`- t.Fatalf("failed to create test dir: %s", err)`
	`81`	`+ t.Skipf("skipping test, failed to create test dir: %s", err)`
`82`	`82`	`}`
`83`	`83`	`t.Cleanup(func() {`
`84`	`84`	`err := os.RemoveAll(dir)`